-
Notifications
You must be signed in to change notification settings - Fork 45
Post milestone3m #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SharonStrats
wants to merge
94
commits into
main
Choose a base branch
from
post-milestone3m
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Post milestone3m #744
Changes from 62 commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
16a6fa9
set updating on click
SharonStrats abb83dd
Merge branch 'main' into fix/checkbox-dblclk
SharonStrats 70f846e
add test for double click
SharonStrats d36adb0
checked login status
SharonStrats d137978
still throw if no pref or error
SharonStrats 6e9b8a0
Update src/login/login.ts
SharonStrats 05965e0
unit test
SharonStrats d71f51e
Merge branch 'fix/pref-error-msg' of https://github.com/SolidOS/solid…
SharonStrats db5bcef
return when not logged in
SharonStrats 2d4aca1
Merge branch 'fix/pref-error-msg' of https://github.com/solidos/solid…
SharonStrats a288ede
Merge branch 'main' into fix/pref-error-msg
SharonStrats 51d40cf
fix test
SharonStrats 96842f8
foundation of shared select component
SharonStrats 21d4030
Add a select webcomponent
SharonStrats 45abfa7
export select webcomponent
SharonStrats 41845b7
minor adj to select
SharonStrats 2367666
fix typescript errors test file
SharonStrats 24aceee
move arrowicon file
SharonStrats b67db1c
combobox web component
SharonStrats a1cd4d3
tests
SharonStrats f2403c7
lint fix
SharonStrats 9711f44
cleanup
SharonStrats fe509c0
photoCapture web component
SharonStrats 84053fd
lint fix
SharonStrats 5c2b0fa
refactor: add manifest-driven v2 component build and export sync
SharonStrats 0da9a83
add button web comp
SharonStrats 1ea3dcb
refactor: reorganize v2 components into grouped source folders
SharonStrats b1cfdc0
remove first comp button
SharonStrats 8a567c0
lint fix
SharonStrats 5a3d725
fix loginButton back to orig
SharonStrats 4dbc0e2
refactor: add theming hooks for button and select
SharonStrats 1c410df
add hover on select
SharonStrats 20da9c9
make bullseye drop friends work a little better
SharonStrats 5ba5ac5
button type for using in js
SharonStrats 040da0a
dragdrop button improvement
SharonStrats 116c32c
Merge branch 'main' into fix/pref-error-msg
SharonStrats 3cd29aa
Merge branch 'fix/pref-error-msg' into post-milestone3m
SharonStrats 5db3791
Merge branch 'main' into fix/checkbox-dblclk
SharonStrats e710b1b
Merge branch 'fix/checkbox-dblclk' into post-milestone3m
SharonStrats cf94f33
test lint error
SharonStrats cb84838
lint error in login
SharonStrats f499141
Make login status background optional
SharonStrats 340f7c8
Prevent early account label truncation
SharonStrats 9f6677c
reverse header changes
SharonStrats 1f9713b
revert login
SharonStrats 270c319
Merge branch 'post-milestone3m' of https://github.com/SolidOS/solid-u…
SharonStrats a06a575
Merge branch 'post-milestone3m' of https://github.com/solidos/solid-u…
SharonStrats e31bcc1
matrix typescript error
SharonStrats bd16140
Update README.md
timea-solid bb13d08
Potential fix for pull request finding
timea-solid bdf77c1
Potential fix for pull request finding
timea-solid d2a19e9
Potential fix for pull request finding
timea-solid 42bbfce
fix registration and login pop up on mobile
SharonStrats 8f01bf0
Potential fix for pull request finding
SharonStrats cb7475e
Merge branch 'post-milestone3m' of https://github.com/solidos/solid-u…
SharonStrats 600641b
fix options on select
SharonStrats 9338ae3
change comment in comp
SharonStrats 210456b
spelling
SharonStrats 7b95a13
try catch widgets forms
SharonStrats 0028d05
photo capture closed by default
SharonStrats db882d9
fix forms break
SharonStrats 9d4f371
Potential fix for pull request finding
SharonStrats cf00980
Potential fix for pull request finding
SharonStrats e4ed803
default options select
SharonStrats d1fd5ec
revert type change matrix
SharonStrats 70398f8
forms fix updating
SharonStrats a06e4ad
select options type
SharonStrats bef7f3c
Merge branch 'post-milestone3m' of https://github.com/SolidOS/solid-u…
SharonStrats 1ee85ca
login pref msging
SharonStrats 037c101
select match other inputs
SharonStrats 5db0091
button: allow text align config
SharonStrats d8fcc5a
button selected
SharonStrats 9bb1bac
Demote tab-widget body from <main> to <div>
m5x5 4251740
fix combobox input sizing
SharonStrats 72d5d75
fix test failure and type errors
SharonStrats 301adfa
Match combobox focus styling to select
SharonStrats 1878d58
rdflib 2.3.8
SharonStrats 5f53850
package and form test
SharonStrats 1f69f76
Render select popup in a portal
SharonStrats 20a4559
Match select styling to combobox
SharonStrats 992d9ea
Match listbox items to menu styling
SharonStrats 9c613dd
Allow spaces while typing in combobox
SharonStrats e448c13
Fix select chevron popup trigger
SharonStrats 3919e51
Adjust selected option hover text color
SharonStrats 4db1752
#351 profile-pane selfie
SharonStrats 9b3c013
lint fix test
SharonStrats 008492b
lock file
SharonStrats be23893
package
SharonStrats 3c71af2
missing scripts
SharonStrats 823c373
jest
SharonStrats 6239b49
fix friends freeze
SharonStrats c3fcf6e
Merge pull request #763 from SolidOS/fix/friend-card-loading
SharonStrats 66476c0
border color select and combo
SharonStrats bcc833a
Merge remote-tracking branch 'origin/main' into post-milestone3m
bourgeoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| export const v2Components = [ | ||
| { | ||
| sourceDir: 'header', | ||
| sourcePath: 'layout/header', | ||
| exportNames: ['header', 'layout/header'] | ||
| }, | ||
| { | ||
| sourceDir: 'loginButton', | ||
| sourcePath: 'auth/loginButton', | ||
| exportNames: ['loginButton', 'login-button', 'auth/login-button'] | ||
| }, | ||
| { | ||
| sourceDir: 'signupButton', | ||
| sourcePath: 'auth/signupButton', | ||
| exportNames: ['auth/signup-button', 'signup-button'] | ||
| }, | ||
| { | ||
| sourceDir: 'photoCapture', | ||
| sourcePath: 'media/photoCapture', | ||
| exportNames: ['media/photo-capture', 'photo-capture'] | ||
| }, | ||
| { | ||
| sourceDir: 'button', | ||
| sourcePath: 'actions/button', | ||
| exportNames: ['actions/button', 'button'] | ||
| }, | ||
| { | ||
| sourceDir: 'footer', | ||
| sourcePath: 'layout/footer', | ||
| exportNames: ['footer', 'layout/footer'] | ||
| }, | ||
| { | ||
| sourceDir: 'select', | ||
| sourcePath: 'forms/select', | ||
| exportNames: ['forms/select', 'select'] | ||
| }, | ||
| { | ||
| sourceDir: 'combobox', | ||
| sourcePath: 'forms/combobox', | ||
| exportNames: ['forms/combobox', 'combobox'] | ||
| } | ||
| ] | ||
|
|
||
| export const componentEntries = Object.fromEntries( | ||
| v2Components.map(({ sourceDir, sourcePath = sourceDir }) => [ | ||
| sourceDir, | ||
| { | ||
| import: `./src/v2/components/${sourcePath}/index.ts` | ||
| } | ||
| ]) | ||
| ) | ||
|
|
||
| export const componentExports = Object.fromEntries( | ||
| v2Components.flatMap(({ sourceDir, exportNames }) => | ||
| exportNames.map(exportName => [ | ||
| `./components/${exportName}`, | ||
| { | ||
| types: `./dist/components/${sourceDir}/index.d.ts`, | ||
| import: `./dist/components/${sourceDir}/index.esm.js`, | ||
| require: `./dist/components/${sourceDir}/index.js` | ||
| } | ||
| ]) | ||
| ) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { readFileSync, writeFileSync } from 'fs' | ||
| import path from 'path' | ||
| import { componentExports } from './component-manifest.mjs' | ||
|
|
||
| const packageJsonPath = path.resolve(process.cwd(), 'package.json') | ||
| const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8')) | ||
|
|
||
| const preservedExports = Object.fromEntries( | ||
| Object.entries(packageJson.exports || {}).filter(([subpath]) => !subpath.startsWith('./components/')) | ||
| ) | ||
|
|
||
| const nextExports = { | ||
| ...preservedExports, | ||
| ...componentExports | ||
| } | ||
|
|
||
| if (JSON.stringify(packageJson.exports || {}) === JSON.stringify(nextExports)) { | ||
| console.log('package.json exports are already in sync') | ||
| process.exit(0) | ||
| } | ||
|
|
||
| packageJson.exports = nextExports | ||
|
|
||
| writeFileSync(packageJsonPath, `${JSON.stringify(packageJson, null, 2)}\n`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { spawn } from 'child_process' | ||
| import { existsSync, watch } from 'fs' | ||
| import path from 'path' | ||
|
|
||
| const scriptsDir = path.resolve(process.cwd(), 'scripts') | ||
| const manifestFile = 'component-manifest.mjs' | ||
| const syncScript = path.resolve(scriptsDir, 'sync-component-exports.mjs') | ||
| let syncTimer = null | ||
| let running = false | ||
| let rerunRequested = false | ||
|
|
||
| const runSync = () => { | ||
| if (running) { | ||
| rerunRequested = true | ||
| return | ||
| } | ||
|
|
||
| running = true | ||
| rerunRequested = false | ||
|
|
||
| const child = spawn(process.execPath, [syncScript], { | ||
| stdio: 'inherit' | ||
| }) | ||
|
|
||
| child.on('exit', code => { | ||
| running = false | ||
|
|
||
| if (code !== 0) { | ||
| console.error(`sync-component-exports exited with code ${code}`) | ||
| } | ||
|
|
||
| if (rerunRequested) { | ||
| runSync() | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| const scheduleSync = () => { | ||
| clearTimeout(syncTimer) | ||
| syncTimer = setTimeout(() => { | ||
| runSync() | ||
| }, 150) | ||
| } | ||
|
|
||
| if (!existsSync(scriptsDir)) { | ||
| throw new Error(`Missing expected directory: ${scriptsDir}`) | ||
| } | ||
|
|
||
| console.log(`Watching ${path.join(scriptsDir, manifestFile)} for export manifest changes...`) | ||
|
|
||
| runSync() | ||
|
|
||
| watch(scriptsDir, (eventType, filename) => { | ||
| if (!filename) return | ||
| if (filename === manifestFile) { | ||
| scheduleSync() | ||
| } | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.