fix: default cron was invalid + changed some logging

Author: SolidProgramming

AniWorldReminder_API/Classes/UpsertEpisodeInfoJob.cs

@@ -1,5 +1,7 @@
 using Hangfire;
 using MethodTimer;
+using Mysqlx.Prepare;
+using System.Reflection;
 using System.Text;
 
 namespace AniWorldReminder_API.Classes
@@ -14,12 +16,19 @@ public class UpsertEpisodeInfoJob(ILogger<UpsertEpisodeInfoJob> logger, IStreami
         [Time]
         public async Task ExecuteAsync()
         {
+            MethodBase? methodBase = typeof(UpsertEpisodeInfoJob).GetMethod(nameof(ExecuteAsync));
+
+            if (methodBase is not null)
+            {
+                MethodTimeLogger.LogExecution(methodBase);
+            }
+
             TelegramBotSettingsModel? botSettings = SettingsHelper.ReadSettings<TelegramBotSettingsModel>();
             AppSettingsModel? appSettings = SettingsHelper.ReadSettings<AppSettingsModel>();
 
             try
             {
-                await CheckForNewEpisodesAsync(botSettings, appSettings);                
+                await CheckForNewEpisodesAsync(botSettings, appSettings);
             }
             catch (Exception ex)
             {

AniWorldReminder_API/Misc/MethodTimeLogger.cs

@@ -16,11 +16,54 @@ public static void Log(MethodBase methodBase, TimeSpan elapsed, string message)
             ILogger logger = (loggerFactory ?? LoggerFactory.Create(_ => { }))
                 .CreateLogger(methodBase.DeclaringType?.FullName ?? "MethodTimer");
 
-            logger.LogInformation(
-                "Method {MethodName} took {ElapsedMs} ms. {Message}",
-                $"{methodBase.DeclaringType?.Name}.{methodBase.Name}",
-                elapsed.TotalMilliseconds,
-                message);
+            string additionalInfo = $" Additional Info: {message}";
+            string duration = $" Runtime: {elapsed:mm}m {elapsed:ss}s.";
+
+            Type? type = methodBase.DeclaringType;
+
+            if (type == null)
+                return;
+
+            Type? @interface = type.GetInterfaces()
+                .FirstOrDefault(i => type.GetInterfaceMap(i).TargetMethods.Any(m => m.DeclaringType == type));
+
+            string info = "Executed ";
+
+            if (@interface is not null && @interface.FullName == "Quartz.IJob" && methodBase.Name == "Execute")
+            {
+                info += $"CronJob: ";
+            }
+
+            logger.LogInformation($"{DateTime.Now} | " + info + "{Class}.{Method}.{Duration}{Message}",
+                methodBase.DeclaringType!.Name,
+                methodBase.Name,
+                (elapsed.Seconds > 0 ? duration : ""),
+                (string.IsNullOrEmpty(message) ? "" : additionalInfo));
+        }
+
+        public static void LogExecution(MethodBase methodBase)
+        {
+            Type? type = methodBase.DeclaringType;
+
+            if (type == null)
+                return;
+
+            Type? @interface = type.GetInterfaces()
+                .FirstOrDefault(i => type.GetInterfaceMap(i).TargetMethods.Any(m => m.DeclaringType == type));
+
+            string info = "Started ";
+
+            if (@interface is not null && @interface.FullName == "Quartz.IJob" && methodBase.Name == "Execute")
+            {
+                info += $"CronJob: ";
+            }
+
+            ILogger logger = (loggerFactory ?? LoggerFactory.Create(_ => { }))
+                .CreateLogger(methodBase.DeclaringType?.FullName ?? "MethodTimer");
+
+            logger.LogInformation($"{DateTime.Now} | " + info + "{Class}.{Method}.",
+                methodBase.DeclaringType!.Name,
+                methodBase.Name);
         }
     }
 }

AniWorldReminder_API/Models/AppSettingsModel.cs

@@ -11,7 +11,7 @@ public class AppSettingsModel
         public bool EnableEpisodeReminderJob { get; set; } = true;
 
         [JsonPropertyName("EpisodeReminderCron")]
-        public string EpisodeReminderCron { get; set; } = "*/15 * * * *";
+        public string EpisodeReminderCron { get; set; } = "0 * * * *";
 
         [JsonPropertyName("EnableHangfireDashboard")]
         public bool EnableHangfireDashboard { get; set; }

AniWorldReminder_API/Program.cs

@@ -178,7 +178,7 @@ public static async Task Main(string[] args)
                 recurringJobManager.AddOrUpdate<UpsertEpisodeInfoJob>(
                     "episode-reminder-scan",
                     job => job.ExecuteAsync(),
-                    appSettings?.EpisodeReminderCron ?? "*/60 * * * *",
+                    appSettings?.EpisodeReminderCron,
                     new RecurringJobOptions
                     {
                         TimeZone = TimeZoneInfo.Local