feat(activity-days): add view's scaffolding#1133
Conversation
|
@greptile |
Greptile SummaryElo żelo solvrowiczu! This PR scaffolds the Activity Days feature, wiring up a new route (
Confidence Score: 5/5Safe to merge as scaffolding; the mock guard and placeholder tabs are intentional and the structural changes are sound. All changes are well-scoped scaffolding. The Freezed models, route registration, and nav bar integration follow existing patterns correctly. The if(true) mock is acknowledged intentional scaffolding while the API is unavailable. Remaining nits are non-blocking for a scaffolding PR. lib/features/activity_days/presentation/activity_days_view.dart (needs a widgetbook story) and packages/widgetbook/lib/features/home_view/widgets/nav_actions_section.stories.dart (needs provider mocking for the new isActivityDaysActive dependency). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
HomeView --> NavActionsSection
NavActionsSection -->|watches| isActivityDaysActiveProvider
isActivityDaysActiveProvider -->|watches| activityDaysRepositoryProvider
activityDaysRepositoryProvider -->|if true mock| MockData[Mock ActivityDaysResponse]
activityDaysRepositoryProvider -.->|future: real API| DAS["/das endpoint"]
NavActionsSection -->|isActive == true| ActivityDaysButton[Activity Days Nav Button]
ActivityDaysButton -->|tap| navigateActivityDays
navigateActivityDays --> ActivityDaysRoute
ActivityDaysRoute --> ActivityDaysView
ActivityDaysView --> TabBar["TabBar (Stands / Timetable / Info)"]
TabBar --> PlaceholderTab["_PlaceholderTab x3"]
Reviews (6): Last reviewed commit: "Merge branch 'das-scaffolding' of github..." | Re-trigger Greptile |
| Future<void> navigateActivityDays() async { | ||
| await _router.push(const ActivityDaysRoute()); | ||
| } |
There was a problem hiding this comment.
Missing analytics tracking event
All other feature-navigation commands in this extension call trackEvent(ClarityEvents.…) before pushing the route (e.g. navigateToSksMenu, navigateAboutUs, navigateToNotifications). navigateActivityDays skips this, so Activity Days usage will be invisible in Clarity analytics.
48b0e96 to
7811fd7
Compare
simon-the-shark
left a comment
There was a problem hiding this comment.
generally very nicely done. I've left few comments + tests are failling
| } on DioException { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
also this catch is not desired, we should just use getAndCacheData
cc32eb0 to
6740f6d
Compare
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
No description provided.