fix: lint errors

Author: jedryczkatymon

public/sw.js

@@ -16,31 +16,31 @@
         - Badges: https://microsoft.github.io/win-student-devs/#/30DaysOfPWA/advanced-capabilities/07?id=application-badges
     */
 
-const HOSTNAME_WHITELIST = [
-  self.location.hostname,
+const HOSTNAME_WHITELIST = new Set([
+  globalThis.location.hostname,
   "fonts.gstatic.com",
   "fonts.googleapis.com",
   "cdn.jsdelivr.net",
-];
+]);
 
 // The Util Function to hack URLs of intercepted requests
-const getFixedUrl = (req) => {
-  var now = Date.now();
-  var url = new URL(req.url);
+const getFixedUrl = (request) => {
+  const now = Date.now();
+  const url = new URL(request.url);
 
   // 1. fixed http URL
   // Just keep syncing with location.protocol
   // fetch(httpURL) belongs to active mixed content.
   // And fetch(httpRequest) is not supported yet.
-  url.protocol = self.location.protocol;
+  url.protocol = globalThis.location.protocol;
 
   // 2. add query for caching-busting.
   // Github Pages served with Cache-Control: max-age=600
   // max-age on mutable content is error-prone, with SW life of bugs can even extend.
   // Until cache mode of Fetch API landed, we have to workaround cache-busting with query string.
   // Cache-Control-Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=453190
-  if (url.hostname === self.location.hostname) {
-    url.search += (url.search ? "&" : "?") + "cache-bust=" + now;
+  if (url.hostname === globalThis.location.hostname) {
+    url.search += `${url.search ? "&" : "?"}cache-bust=${now}`;
   }
   return url.href;
 };
@@ -51,8 +51,8 @@ const getFixedUrl = (req) => {
  *
  *  waitUntil(): activating ====> activated
  */
-self.addEventListener("activate", (event) => {
-  event.waitUntil(self.clients.claim());
+globalThis.addEventListener("activate", (event) => {
+  event.waitUntil(globalThis.clients.claim());
 });
 
 /**
@@ -61,9 +61,9 @@ self.addEventListener("activate", (event) => {
  *
  *  void respondWith(Promise<Response> r)
  */
-self.addEventListener("fetch", (event) => {
+globalThis.addEventListener("fetch", (event) => {
   // Skip some of cross-origin requests, like those for Google Analytics.
-  if (HOSTNAME_WHITELIST.indexOf(new URL(event.request.url).hostname) > -1) {
+  if (HOSTNAME_WHITELIST.has(new URL(event.request.url).hostname) > -1) {
     // Stale-while-revalidate
     // similar to HTTP's stale-while-revalidate: https://www.mnot.net/blog/2007/12/12/stale
     // Upgrade from Jake's to Surma's: https://gist.github.com/surma/eb441223daaedf880801ad80006389f1

src/components/service-worker-register.tsx

@@ -8,13 +8,13 @@ export function ServiceWorkerRegister() {
       window.addEventListener("load", () => {
         navigator.serviceWorker.register("/sw.js").then(
           (registration) => {
-            console.log(
-              "Service Worker registration successful with scope: ",
+            console.warn(
+              "Service Worker registration successful with scope:",
               registration.scope,
             );
           },
-          (err) => {
-            console.error("Service Worker registration failed: ", err);
+          (error: unknown) => {
+            console.error("Service Worker registration failed:", error);
           },
         );
       });