🐛 fix the handling of empty journal and status events

semver: patch

Author: Somfic

.gitignore

@@ -600,3 +600,4 @@ vite.config.ts.timestamp-*
 .direnv/
 result
 result-*
+/.claude

EliteAPI.Tests/FlatteningTests.cs

@@ -523,4 +523,40 @@ public void NullInNestedObject()
 
         paths.Should().BeEquivalentTo(expected);
     }
+
+    [Test]
+    public void GetEventName_WithEmptyString_ReturnsEmptyString()
+    {
+        var json = "";
+        var eventName = JsonUtils.GetEventName(json);
+
+        eventName.Should().BeEmpty();
+    }
+
+    [Test]
+    public void GetEventName_WithWhitespace_ReturnsEmptyString()
+    {
+        var json = "   ";
+        var eventName = JsonUtils.GetEventName(json);
+
+        eventName.Should().BeEmpty();
+    }
+
+    [Test]
+    public void GetEventName_WithValidEvent_ReturnsEventName()
+    {
+        var json = """{ "event": "TestEvent", "timestamp": "2025-01-01T00:00:00Z" }""";
+        var eventName = JsonUtils.GetEventName(json);
+
+        eventName.Should().Be("TestEvent");
+    }
+
+    [Test]
+    public void GetEventName_WithNoEventField_ReturnsEmptyString()
+    {
+        var json = """{ "timestamp": "2025-01-01T00:00:00Z" }""";
+        var eventName = JsonUtils.GetEventName(json);
+
+        eventName.Should().BeEmpty();
+    }
 }

EliteAPI.Tests/StatusChangeEventTests.cs

@@ -251,4 +251,34 @@ public void FiresChangeEvent_ForBalance_WhenItChanges()
 
         balanceChangeEventFired.Should().BeTrue();
     }
+
+    [Test]
+    public void DoesNotThrow_WhenJsonIsEmpty()
+    {
+        var api = new EliteDangerousApi(null, null);
+        var anyEventFired = false;
+
+        api.OnAllJson(e => anyEventFired = true);
+
+        var emptyJson = "";
+        var invokeAction = () => api.Invoke(emptyJson);
+
+        invokeAction.Should().NotThrow("empty JSON should be handled gracefully");
+        anyEventFired.Should().BeFalse("no events should fire for empty JSON");
+    }
+
+    [Test]
+    public void DoesNotThrow_WhenJsonIsWhitespace()
+    {
+        var api = new EliteDangerousApi(null, null);
+        var anyEventFired = false;
+
+        api.OnAllJson(e => anyEventFired = true);
+
+        var whitespaceJson = "   ";
+        var invokeAction = () => api.Invoke(whitespaceJson);
+
+        invokeAction.Should().NotThrow("whitespace JSON should be handled gracefully");
+        anyEventFired.Should().BeFalse("no events should fire for whitespace JSON");
+    }
 }

EliteAPI/EliteDangerousApi.cs

@@ -32,7 +32,7 @@ public class EliteDangerousApi
     private readonly List<Action<IReadOnlyCollection<Control>>> _bindingsHandlers = [];
 
     public Version Version => typeof(EliteDangerousApi).Assembly.GetName().Version!;
-    
+
     public EliteDangerousApi() : this(JournalUtils.GetJournalsDirectory(), BindingsUtils.GetBindingsDirectory())
     {
     }
@@ -53,7 +53,7 @@ public EliteDangerousApi(DirectoryInfo? journalDirectory, DirectoryInfo? binding
                 "Outfitting.json",
                 "ShipLocker.json",
                 "Shipyard.json",
-                "Status.json"
+                "Status.json",
             ];
 
             _statusWatchers = statusFiles
@@ -186,6 +186,12 @@ public void Invoke(IEvent @event)
 
     internal void Invoke(string json, IEvent? @event)
     {
+        if (string.IsNullOrWhiteSpace(json))
+        {
+            Log.Debug("Skipping empty event");
+            return;
+        }
+
         var eventName = JsonUtils.GetEventName(json);
         if (string.IsNullOrEmpty(eventName))
         {

EliteAPI/Json/JsonUtils.cs

@@ -16,6 +16,9 @@ public static class JsonUtils
 
     public static string GetEventName(string json)
     {
+        if (string.IsNullOrWhiteSpace(json))
+            return string.Empty;
+
         var obj = JObject.Parse(json);
 
         {
@@ -33,6 +36,9 @@ public static string GetEventName(string json)
 
     public static List<EventPath> FlattenJson(string json)
     {
+        if (string.IsNullOrWhiteSpace(json))
+            return [];
+
         // TODO: call flattening function
         // arrays need Length 
         // key + localisation