✨ make a distinction between valid and invalid bindings

semver: minor

Author: Somfic

EliteAPI/Bindings/BindingsUtils.cs

@@ -2,7 +2,9 @@
 using System.Collections.Generic;
 using System.IO;
 
-public class BindingsUtils
+namespace EliteAPI.Bindings;
+
+public static class BindingsUtils
 {
     private static readonly Dictionary<string, string> KeyCodeMap = new(StringComparer.OrdinalIgnoreCase)
     {
@@ -183,7 +185,7 @@ private static DirectoryInfo GetOptionsDirectory()
         return new DirectoryInfo(Path.Combine(localAppData, "Frontier Developments", "Elite Dangerous", "Options"));
     }
 
-    internal static string GetKeyCode(string key)
+    internal static string GetKeyCode(string? key)
     {
         if (key == null)
             return "-1";
@@ -192,4 +194,4 @@ internal static string GetKeyCode(string key)
 
         return $"[{keyCode}]";
     }
-}
+}

EliteAPI/bindings/Binding.cs

@@ -8,7 +8,7 @@ public readonly struct Binding
 
     public string Key { get; init; }
 
-    public string KeyCode => $"{string.Join("", Modifiers?.Select(m => m.KeyCode) ?? Enumerable.Empty<string>())}{BindingsUtils.GetKeyCode(Key)}";
+    public string KeyCode => $"{string.Join("", Modifiers?.Select(m => m.KeyCode) ?? [])}{BindingsUtils.GetKeyCode(Key)}";
 
     public Binding[]? Modifiers { get; init; }
 

EliteAPI/bindings/Control.cs

@@ -13,6 +13,8 @@ public readonly struct Control
     public bool? IsInverted { get; init; }
 
     public float? Deadzone { get; init; }
+
+    public bool IsValid => !string.IsNullOrEmpty(KeyCode);
 
     public string KeyCode { get {
         if (Primary is { Device: "Keyboard" })