fix(review): address PR feedback on isExpectCall and chain-order docs

- Replace the isUnresolved-based fallback in isExpectCall with a
  narrower isGlobalExpect check (no variable, or a variable with no
  declarations) to avoid misclassifying a shadowed local `expect`
  (e.g. a function parameter) as the framework global.
- Fix collectCallChain's JSDoc: segments are collected furthest from
  the root call first, not "innermost first".

Author: nathsou

packages/analysis/src/jsts/rules/S8967/rule.ts

@@ -18,7 +18,7 @@
 
 import type { Rule } from 'eslint';
 import type estree from 'estree';
-import { isIdentifier, isMethodCall, isUnresolved } from '../helpers/ast.js';
+import { getVariableFromName, isIdentifier, isMethodCall } from '../helpers/ast.js';
 import { collectCallChain, getRootCall } from '../helpers/expect-call-chain.js';
 import { generateMeta } from '../helpers/generate-meta.js';
 import { getFullyQualifiedName, importsOrDependsOnModule } from '../helpers/module.js';
@@ -128,6 +128,11 @@ function isExpectCall(
   return (
     (frameworks.jest || frameworks.vitest) &&
     isIdentifier(call.callee, 'expect') &&
-    isUnresolved(call.callee, context)
+    isGlobalExpect(context, call.callee)
   );
 }
+
+function isGlobalExpect(context: Rule.RuleContext, node: estree.Identifier): boolean {
+  const variable = getVariableFromName(context, node.name, node);
+  return !variable || variable.defs.length === 0;
+}

packages/analysis/src/jsts/rules/helpers/expect-call-chain.ts

@@ -30,8 +30,9 @@ export function unwrapChainExpression<T extends estree.Node | estree.Super>(
 }
 
 /**
- * Collects the chain of member names hung off `call`, innermost first, e.g. for
- * `expect(x).not.resolves.toBe(y)` called with the `toBe(y)` node, returns
+ * Collects the chain of member names hung off `call`, furthest from the root
+ * call first, e.g. for `expect(x).not.resolves.toBe(y)` called with the `toBe(y)`
+ * node, returns
  * `{ segments: [{name: 'toBe', ...}, {name: 'resolves', ...}, {name: 'not', ...}], complete: true }`.
  * `complete` is `false` when a computed member or non-identifier property was hit
  * before reaching the root call, in which case `segments` only holds the