Skip to content

JS-1981 Expose propNamePattern for S6478#7423

Merged
francois-mora-sonarsource merged 3 commits into
masterfrom
JS-1981
Jul 8, 2026
Merged

JS-1981 Expose propNamePattern for S6478#7423
francois-mora-sonarsource merged 3 commits into
masterfrom
JS-1981

Conversation

@francois-mora-sonarsource

Copy link
Copy Markdown
Contributor

Summary

  • expose propNamePattern alongside allowAsProps for S6478
  • keep the upstream default glob semantics (render*) and describe the option as a prop-name glob
  • add focused tests covering render*, *Enhancer, and *Render suppression while keeping non-matching props noncompliant

Validation

  • npm run generate-meta
  • npx tsx --test packages/analysis/src/jsts/rules/S6478/**/*.test.ts

Notes

  • npm run generate-java-rule-classes completes with an unrelated RSPEC metadata not found for rule S8957. warning in this checkout

@francois-mora-sonarsource
francois-mora-sonarsource requested a review from a team July 1, 2026 14:05
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 1, 2026

Copy link
Copy Markdown

JS-1981

@francois-mora-sonarsource
francois-mora-sonarsource requested a review from a team July 1, 2026 14:27
@datadog-sonarsource

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Ruling Report

No changes to ruling expected issues in this PR

@francois-mora-sonarsource
francois-mora-sonarsource removed the request for review from a team July 2, 2026 13:07
Comment thread packages/analysis/src/jsts/rules/S6478/unit.test.ts Outdated
Comment thread packages/analysis/src/jsts/rules/S6478/unit.test.ts Outdated
Comment thread packages/analysis/src/jsts/rules/S6478/config.ts Outdated
@sonarqube-next

sonarqube-next Bot commented Jul 3, 2026

Copy link
Copy Markdown

@francois-mora-sonarsource
francois-mora-sonarsource merged commit 50daa7b into master Jul 8, 2026
48 checks passed
@francois-mora-sonarsource
francois-mora-sonarsource deleted the JS-1981 branch July 8, 2026 15:32
@gitar-bot

gitar-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Exposes the propNamePattern configuration option for S6478, allowing custom glob patterns for render-prop names. Verified via updated test coverage for standard and custom patterns.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants