Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions manifest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ description = 'Sonar Plugin API - Manifest'
dependencies {
compileOnly libs.jsr305

api project(':shared')
implementation libs.commons.lang3

testImplementation libs.junit5
Expand All @@ -17,6 +18,7 @@ publishing {
publications {
mavenJava(MavenPublication) {
artifactId = 'sonar-plugin-manifest'
from components.java
Comment thread
henryju marked this conversation as resolved.
pom {
name = 'Sonar Plugin API - Manifest'
description = 'Sonar Plugin API - Manifest'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import javax.annotation.Nullable;
import org.apache.commons.lang3.StringUtils;
import org.apache.commons.lang3.builder.ReflectionToStringBuilder;
import org.sonar.api.utils.Version;

/**
* This class loads Sonar plugin metadata from JAR manifest.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

import java.util.regex.Pattern;
import org.apache.commons.lang3.StringUtils;
import org.sonar.api.utils.Version;

public class RequiredPlugin {

Expand Down
149 changes: 0 additions & 149 deletions manifest/src/main/java/org/sonar/plugin/api/manifest/Version.java

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.util.jar.Attributes;
import java.util.jar.Manifest;
import org.junit.jupiter.api.Test;
import org.sonar.api.utils.Version;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class RequiredPluginTest {
void test_RequiredPlugin() {
var plugin = RequiredPlugin.parse("java:1.1");
assertThat(plugin.getKey()).isEqualTo("java");
assertThat(plugin.getMinimalVersion().getName()).isEqualTo("1.1");
assertThat(plugin.getMinimalVersion()).hasToString("1.1");

assertThrows(IllegalArgumentException.class, () -> RequiredPlugin.parse("java"));
}
Expand Down
Loading
Loading