Skip to content

PLUGINAPI-186 Deprecate PropertyDefinitions#284

Merged
antoine-vinot-sonarsource merged 1 commit intomasterfrom
avi/deprecate-property-definitions
Apr 3, 2026
Merged

PLUGINAPI-186 Deprecate PropertyDefinitions#284
antoine-vinot-sonarsource merged 1 commit intomasterfrom
avi/deprecate-property-definitions

Conversation

@antoine-vinot-sonarsource
Copy link
Copy Markdown
Contributor

No description provided.

@antoine-vinot-sonarsource antoine-vinot-sonarsource requested a review from a team as a code owner April 3, 2026 13:22
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Deprecate PropertyDefinitions PLUGINAPI-186 Deprecate PropertyDefinitions Apr 3, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod bot commented Apr 3, 2026

PLUGINAPI-186

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha bot commented Apr 3, 2026

Summary

Deprecates the PropertyDefinitions class (marked for removal) in favor of PropertyDefinition.builder(String). This is a backward-compatible change that signals to plugin authors they should migrate to the modern API. The CHANGELOG is updated to document this change for version 13.6.

What reviewers should know

This is a straightforward deprecation with minimal changes: the @Deprecated annotation with removal flag, a Javadoc deprecation notice pointing to the replacement API, and a changelog entry. All changes are in two files (PropertyDefinitions.java and CHANGELOG.md). No code behavior is affected — this is purely a signal to encourage migration to the newer PropertyDefinition.builder() API.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as outdated.

@antoine-vinot-sonarsource antoine-vinot-sonarsource force-pushed the avi/deprecate-property-definitions branch from 3f38492 to 3111fbb Compare April 3, 2026 13:28
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal deprecation PR — no issues found.

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

sonarqube-next bot commented Apr 3, 2026

@antoine-vinot-sonarsource antoine-vinot-sonarsource merged commit 9e91c1b into master Apr 3, 2026
7 checks passed
@antoine-vinot-sonarsource antoine-vinot-sonarsource deleted the avi/deprecate-property-definitions branch April 3, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants