PLUGINAPI-200 Add explicit CPD unit boundaries to NewCpdTokens

[henryju]

Lets a sensor group tokens into CPD units via explicit withExplicitUnitBoundaries()/endUnit() calls instead of the default per-physical-line grouping, so languages using statement-shaped units (e.g. Java) don't need to bypass NewCpdTokens entirely.

[hashicorp-vault-sonar-prod]

PLUGINAPI-200

[gitar-bot]

💡 Quality: New abstract methods on public interface break implementers

Adding withExplicitUnitBoundaries() and endUnit() as abstract methods to the published NewCpdTokens interface is a source/binary-incompatible change for any code that implements the interface (test doubles, alternative scanner impls). Consider providing default implementations (e.g. endUnit() throwing UnsupportedOperationException and withExplicitUnitBoundaries() returning this) so existing implementers keep compiling, consistent with how additive interface methods are typically handled in a stable plugin API.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Introduces explicit CPD unit boundaries to the NewCpdTokens interface to support statement-shaped token grouping. Adding these as abstract methods creates a binary compatibility break for existing interface implementers; consider providing default implementations instead.

💡 Quality: New abstract methods on public interface break implementers

📄 plugin-api/src/main/java/org/sonar/api/batch/sensor/cpd/NewCpdTokens.java:89 📄 plugin-api/src/main/java/org/sonar/api/batch/sensor/cpd/NewCpdTokens.java:96

Adding withExplicitUnitBoundaries() and endUnit() as abstract methods to the published NewCpdTokens interface is a source/binary-incompatible change for any code that implements the interface (test doubles, alternative scanner impls). Consider providing default implementations (e.g. endUnit() throwing UnsupportedOperationException and withExplicitUnitBoundaries() returning this) so existing implementers keep compiling, consistent with how additive interface methods are typically handled in a stable plugin API.

🤖 Prompt for agents

Code Review: Introduces explicit CPD unit boundaries to the NewCpdTokens interface to support statement-shaped token grouping. Adding these as abstract methods creates a binary compatibility break for existing interface implementers; consider providing default implementations instead.

1. 💡 Quality: New abstract methods on public interface break implementers
   Files: plugin-api/src/main/java/org/sonar/api/batch/sensor/cpd/NewCpdTokens.java:89, plugin-api/src/main/java/org/sonar/api/batch/sensor/cpd/NewCpdTokens.java:96

   Adding `withExplicitUnitBoundaries()` and `endUnit()` as abstract methods to the published `NewCpdTokens` interface is a source/binary-incompatible change for any code that implements the interface (test doubles, alternative scanner impls). Consider providing `default` implementations (e.g. `endUnit()` throwing UnsupportedOperationException and `withExplicitUnitBoundaries()` returning `this`) so existing implementers keep compiling, consistent with how additive interface methods are typically handled in a stable plugin API.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube