Skip to content

Commit 39a0e6d

Browse files
Seppli11sonartech
authored andcommitted
SONARPY-3250 S6243: document FP (#439)
GitOrigin-RevId: 3e6d4a7f9f0740286d569d3ac600c6ef5427f22a
1 parent 8443dbc commit 39a0e6d

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

python-checks/src/main/java/org/sonar/python/checks/AwsLambdaClientInstantiationCheck.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public class AwsLambdaClientInstantiationCheck extends PythonSubscriptionCheck {
6060

6161
private final TypeCheckMap<String> isClientOrResourceTypeCheckMap = new TypeCheckMap<>();
6262

63+
@Override
6364
public void initialize(Context context) {
6465
context.registerSyntaxNodeConsumer(Tree.Kind.FILE_INPUT, this::setupTypeChecker);
6566
context.registerSyntaxNodeConsumer(Tree.Kind.CALL_EXPR, this::checkCall);

python-checks/src/test/resources/checks/awsLambdaClientInstantiation.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,23 @@ def lambda_handler(event, context):
3939

4040
mongoengine_connection = mongoengine.connect('project1') # Noncompliant
4141

42+
def fps_client_created_from_event_handler(event, context):
43+
# FPs from SONARPY-3242
44+
45+
s3_client = boto3.client('s3', event) # Noncompliant
46+
47+
s3_client = boto3.client('s3', event['region']) # Noncompliant
48+
49+
s3_client = boto3.client('s3', context.get_remaining_time_in_millis()) # Noncompliant
50+
s3_client = boto3.client('s3', context.function_name) # Noncompliant
51+
52+
region = get_region(event)
53+
s3_client = boto3.client('s3', region) # Noncompliant
54+
55+
56+
def get_region(event):
57+
return event
58+
4259

4360
s3_client = boto3.client('s3')
4461
s3 = boto3.resource('s3')

0 commit comments

Comments
 (0)