SONARPY-3122 S7503 should not raise issues on async comprehensions (#365)

GitOrigin-RevId: 280765d366209ef9fd451c4bbaf994f53454c92f

Author: ghislainpiot

python-checks/src/main/java/org/sonar/python/checks/AsyncFunctionNotAsyncCheck.java

@@ -17,11 +17,13 @@
 package org.sonar.python.checks;
 
 import javax.annotation.Nullable;
+
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
 import org.sonar.plugins.python.api.tree.AwaitExpression;
 import org.sonar.plugins.python.api.tree.BaseTreeVisitor;
+import org.sonar.plugins.python.api.tree.ComprehensionFor;
 import org.sonar.plugins.python.api.tree.ForStatement;
 import org.sonar.plugins.python.api.tree.FunctionDef;
 import org.sonar.plugins.python.api.tree.ReturnStatement;
@@ -150,6 +152,12 @@ public void visitFunctionDef(FunctionDef functionDef) {
       // Skip nested functions
     }
 
+    @Override
+    public void visitComprehensionFor(ComprehensionFor tree) {
+      asyncFeatureFound |= tree.asyncToken() != null;
+      super.visitComprehensionFor(tree);
+    }
+
     @Override
     protected void scan(@Nullable Tree tree) {
       // Stop scanning if we've already found an async feature

python-checks/src/test/resources/checks/asyncFunctionNotAsync.py

@@ -142,7 +142,7 @@ async def __anext__(self):
 class AsyncResource:
     async def __aclose__(self):
         print("Releasing resources")
-        
+
 class AsyncAwaitableObject:
     async def __await__(self):
         yield "something"
@@ -183,3 +183,9 @@ class MyOtherClass(MyClass):
     async def my_method(self):
         # No issue on overriding methods
         do_something()
+
+async def async_comprehension():
+    return [something async for something in async_iterable()]
+
+async def sync_comprehension(): # Noncompliant
+    return [something for something in async_iterable()]