SONARPY-3126 S7519: F-Strings are not constant and should not trigger the rule (#367)

GitOrigin-RevId: a6def97c63a5ac332079721065179a41cf4d588d

Author: ghislainpiot

python-checks/src/main/java/org/sonar/python/checks/ConstantValueDictComprehensionCheck.java

@@ -16,11 +16,15 @@
  */
 package org.sonar.python.checks;
 
+import java.util.List;
+
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
 import org.sonar.plugins.python.api.tree.DictCompExpression;
 import org.sonar.plugins.python.api.tree.Name;
+import org.sonar.plugins.python.api.tree.StringElement;
+import org.sonar.plugins.python.api.tree.StringLiteral;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.python.semantic.v2.UsageV2;
 import org.sonar.python.tree.TreeUtils;
@@ -55,10 +59,10 @@ private static boolean isConstantValueDictComprehension(DictCompExpression dictC
         .stream()
         .map(UsageV2::tree)
         .allMatch(ut -> TreeUtils.firstAncestor(ut, dictComprehension::equals) != null);
+    } else if (dictComprehension.valueExpression() instanceof StringLiteral stringLiteral) {
+      return stringLiteral.stringElements().stream().map(StringElement::formattedExpressions).allMatch(List::isEmpty);
     } else {
-      return dictComprehension.valueExpression().is(Tree.Kind.NONE, Tree.Kind.STRING_LITERAL, Tree.Kind.NUMERIC_LITERAL, Tree.Kind.BOOLEAN_LITERAL_PATTERN);
+      return dictComprehension.valueExpression().is(Tree.Kind.NONE, Tree.Kind.NUMERIC_LITERAL, Tree.Kind.BOOLEAN_LITERAL_PATTERN);
     }
   }
-
-
 }

python-checks/src/test/resources/checks/constantValueDictComprehension.py

@@ -18,4 +18,10 @@ def case2():
 
 def case3():
     some_list = ["a/b", "c/d"]
-    result = {q.split("/")[-1]: q for q in some_list}
+    result = {q.split("/")[-1]: q for q in some_list}
+
+def case4(columns_to_save):
+    mapping = {col: f"new.{col}" for col in columns_to_save}
+    some_v = "v"
+    some_dict = {"a": "1", "b": "2"}
+    one_more = {k: f"{some_v}" for k, v in some_dict} # FN