SONARPY-3116 Use appropriate operator (java:S1940)

Wohops · sonartech · commit 73c707a09015 · 2025-06-27T10:10:52.000Z
GitOrigin-RevId: 374bc94bd6692d5e22c756095a5361b55bb1fc34
diff --git a/python-checks-testkit/src/main/java/org/sonar/python/checks/quickfix/PythonQuickFixVerifier.java b/python-checks-testkit/src/main/java/org/sonar/python/checks/quickfix/PythonQuickFixVerifier.java
@@ -216,9 +216,9 @@ private static boolean oneEnclosedByTheOther(PythonTextEdit toCheck, PythonTextE
         } else {
           // There is an intersection between edits, only need to check valid case
           if (reference.startLine() == toCheck.endLine()) {
-            return !(toCheck.endLineOffset() <= reference.startLineOffset());
+            return toCheck.endLineOffset() > reference.startLineOffset();
           } else if (reference.endLine() == toCheck.startLine()) {
-            return !(reference.endLineOffset() <= toCheck.startLineOffset());
+            return reference.endLineOffset() > toCheck.startLineOffset();
           }
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -216,9 +216,9 @@ private static boolean oneEnclosedByTheOther(PythonTextEdit toCheck, PythonTextE`
`216`	`216`	`} else {`
`217`	`217`	`// There is an intersection between edits, only need to check valid case`
`218`	`218`	`if (reference.startLine() == toCheck.endLine()) {`
`219`		`- return !(toCheck.endLineOffset() <= reference.startLineOffset());`
	`219`	`+ return toCheck.endLineOffset() > reference.startLineOffset();`
`220`	`220`	`} else if (reference.endLine() == toCheck.startLine()) {`
`221`		`- return !(reference.endLineOffset() <= toCheck.startLineOffset());`
	`221`	`+ return reference.endLineOffset() > toCheck.startLineOffset();`
`222`	`222`	`}`
`223`	`223`	`}`
`224`	`224`	`}`