Skip to content

Commit c5b9982

Browse files
guillaume-dequennesonartech
authored andcommitted
Fix ITs plugin location and update telemetry comments
Fix the relative path for python-custom-rules-example in PluginLocator, and update the telemetry-disable comment to reflect the real reason (avoiding external network calls) rather than a transient ticket reference. GitOrigin-RevId: 3dcb75ee2bf81673c414af4cb7e9ee8284ff6eea
1 parent ac96e16 commit c5b9982

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

its/commons/src/test/java/com/sonar/python/it/PluginLocator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public enum Plugins {
3333
new LocalPlugin("../python-custom-rules-plugin/target", "python-custom-rules-plugin-*.jar"),
3434
new LocalPlugin("../../../its/plugin/python-custom-rules-plugin/target", "python-custom-rules-plugin-*.jar")),
3535
PYTHON_CUSTOM_RULES_EXAMPLE(
36-
new LocalPlugin("../../docs/python-custom-rules-example/target", "python-custom-rules-example-*.jar"),
36+
new LocalPlugin("../../../docs/python-custom-rules-example/target", "python-custom-rules-example-*.jar"),
3737
new LocalPlugin("../../../docs/python-custom-rules-example/target", "python-custom-rules-example-*.jar"));
3838

3939
private final LocalPlugin ossPlugin;

its/commons/src/test/java/com/sonar/python/it/TestsUtils.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,8 @@ private static ConcurrentOrchestratorExtension.ConcurrentOrchestratorExtensionBu
5757
var builder = ConcurrentOrchestratorExtension.builderEnv()
5858
.useDefaultAdminCredentialsForBuilds(true)
5959
.setSonarVersion(System.getProperty(SQ_VERSION_PROPERTY, DEFAULT_SQ_VERSION))
60-
// Disable telemetry waiting for ORCH-497
60+
// Disable telemetry to avoid external network calls during tests
6161
.setServerProperty("sonar.telemetry.enable", "false")
62-
63-
// Custom rules plugin
6462
.addPlugin(Plugins.PYTHON_CUSTOM_RULES.get(isEnterprise))
6563
.addPlugin(Plugins.PYTHON_CUSTOM_RULES_EXAMPLE.get(isEnterprise))
6664
.restoreProfileAtStartup(FileLocation.of("profiles/profile-python-custom-rules-example.xml"))

0 commit comments

Comments
 (0)