SONARPY-3128 S7500: Rule should not raise on async comprehensions (#353)

GitOrigin-RevId: e4daf35e2ae2d85ca4bada689d8f59aa1f75148e

Author: thomas-serre-sonarsource

python-checks/src/main/java/org/sonar/python/checks/UnnecessaryComprehensionCheck.java

@@ -56,7 +56,7 @@ private static void checkComprehensionExpression(SubscriptionContext ctx) {
     var valueExpression = comprehension.resultExpression();
     var loopExpression = Optional.of(comprehension)
       .map(ComprehensionExpression::comprehensionFor)
-      .filter(comprehensionFor -> Objects.isNull(comprehensionFor.nestedClause()))
+      .filter(comprehensionFor -> Objects.isNull(comprehensionFor.nestedClause()) && comprehensionFor.asyncToken() == null)
       .map(ComprehensionFor::loopExpression)
       .orElse(null);
 
@@ -75,7 +75,7 @@ private static void checkDictComprehensionExpression(SubscriptionContext ctx) {
     var valueExpression = comprehension.valueExpression();
     var loopExpressions = Optional.of(comprehension)
       .map(DictCompExpression::comprehensionFor)
-      .filter(comprehensionFor -> Objects.isNull(comprehensionFor.nestedClause()))
+      .filter(comprehensionFor -> Objects.isNull(comprehensionFor.nestedClause()) && comprehensionFor.asyncToken() == null)
       .map(ComprehensionFor::loopExpression)
       .map(TreeUtils.toInstanceOfMapper(Tuple.class))
       .map(Tuple::elements)

python-checks/src/test/resources/checks/unnecessaryComprehension.py

@@ -26,3 +26,16 @@ def case2():
   dict_comp = {k: v for k, v in iterable_pairs if something(k)}
   dict_comp = {k: v1 for k, v2 in iterable_pairs}
   dict_comp = {k1: v for k2, v in iterable_pairs}
+
+def async_case():
+
+    from somewhere import async_generator, async_pair_generator
+
+    iterable_single = aiter(async_generator())
+    list_comp = [x async for x in iterable_single]
+    set_comp = {x async for x in iterable_single}
+    list_comp = list(x async for x in iterable_single)
+    set_comp = set(x async for x in iterable_single)
+
+    iterable_pairs = aiter(async_pair_generator())
+    dict_comp = {k: v async for k, v in iterable_pairs}