SONARPY-3344: S5727: Should not raise an issue when checking if kwargs is not None (#492)

GitOrigin-RevId: 73707d1d08a5eb36e98abdcbab6e71068c26b9fe

Author: joke1196

python-checks/src/main/java/org/sonar/python/checks/ComparisonToNoneCheck.java

@@ -19,12 +19,17 @@
 import org.sonar.check.Rule;
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
 import org.sonar.plugins.python.api.SubscriptionContext;
+import org.sonar.plugins.python.api.symbols.Symbol;
+import org.sonar.plugins.python.api.symbols.Usage;
 import org.sonar.plugins.python.api.tree.BinaryExpression;
+import org.sonar.plugins.python.api.tree.Expression;
 import org.sonar.plugins.python.api.tree.IsExpression;
+import org.sonar.plugins.python.api.tree.Parameter;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.tree.Tree.Kind;
 import org.sonar.plugins.python.api.types.BuiltinTypes;
 import org.sonar.plugins.python.api.types.InferredType;
+import org.sonar.python.tree.TreeUtils;
 
 import static org.sonar.python.checks.utils.CheckUtils.isNone;
 
@@ -54,8 +59,12 @@ private static void checkEqualityComparison(SubscriptionContext ctx, BinaryExpre
   private static void checkIdentityComparison(SubscriptionContext ctx, IsExpression comparison) {
     InferredType left = comparison.leftOperand().type();
     InferredType right = comparison.rightOperand().type();
+
     // `isObject` Removes FP when the return type of a function is an object
-    if (!left.isIdentityComparableWith(right) && (isNone(left) || isNone(right)) && !(isObject(left) || isObject(right))) {
+    // `isArgsOrKwargs` Removes FP when *args or **kwargs are used as their type are tuple and dict when type hinted with `Any`.
+    var isIdentityComparableWith = left.isIdentityComparableWith(right);
+    var isOperandArgsOrKwargs = isArgsOrKwargs(comparison.leftOperand()) || isArgsOrKwargs(comparison.rightOperand());
+    if (!isIdentityComparableWith && (isNone(left) || isNone(right)) && !(isObject(left) || isObject(right)) && !isOperandArgsOrKwargs) {
       addIssue(ctx, comparison, "identity check", comparison.notToken() != null);
     } else if (isNone(left) && isNone(right)) {
       addIssue(ctx, comparison, "identity check", comparison.notToken() == null);
@@ -75,4 +84,12 @@ private static boolean isObject(InferredType type) {
     return type.canOnlyBe(BuiltinTypes.OBJECT_TYPE);
   }
 
+  private static boolean isArgsOrKwargs(Expression expr) {
+    return TreeUtils.getSymbolFromTree(expr).map(Symbol::usages)
+      .map(usages -> usages.stream().anyMatch(ComparisonToNoneCheck::isUsedAsArgsOrKwargs)).orElse(false);
+  }
+
+  private static boolean isUsedAsArgsOrKwargs(Usage usage) {
+    return usage.tree().parent() instanceof Parameter parameter && parameter.starToken() != null;
+  }
 }

python-checks/src/test/resources/checks/comparisonToNoneCheck.py

@@ -1,4 +1,6 @@
+from typing import Any, Tuple, Dict
 import pydoc
+
 def identity_check(param):
     a = None
     b = 42
@@ -50,3 +52,10 @@ def equality_check(param):
     if obj == None: pass # FN
     if None == obj: pass # FN
 
+def kwargs_any(*args: Any, **some_dict:Any):
+    if args is not None: ...
+    if some_dict is not None: ...
+
+def kwargs(*some_args: Any, **kwargs: Any):
+    if kwargs is not None: ...
+    if some_args is not None: ...