SONARPY-3127 Fix S7498 Rule: should not raise if an type annotation is present

GitOrigin-RevId: a823fc6e9ab59551d5653bedd953c57ba287f019

Author: maksim-grebeniuk-sonarsource

python-checks/src/main/java/org/sonar/python/checks/EmptyCollectionConstructorCheck.java

@@ -25,6 +25,7 @@
 import org.sonar.plugins.python.api.tree.CallExpression;
 import org.sonar.plugins.python.api.tree.Expression;
 import org.sonar.plugins.python.api.tree.RegularArgument;
+import org.sonar.plugins.python.api.tree.SubscriptionExpression;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.types.v2.TriBool;
 import org.sonar.python.quickfix.TextEditUtils;
@@ -73,7 +74,7 @@ private boolean isUnnecessaryCollectionConstructor(CallExpression callExpression
 
   private boolean isCollectionConstructor(Expression calleeExpression) {
     var type = calleeExpression.typeV2();
-    return collectionConstructorTypeCheckers.getOptionalForType(type).isPresent();
+    return collectionConstructorTypeCheckers.getOptionalForType(type).isPresent() && !(calleeExpression instanceof SubscriptionExpression);
   }
 
   private static boolean isEmptyCall(CallExpression callExpression) {

python-checks/src/test/resources/checks/emptyCollectionConstructor.py

@@ -49,3 +49,6 @@ def dict(): pass
     tuple()
     set()
     dict()
+
+def empty_collection_with_generic_type_hint():
+    list[int | None]()