SONARPY-3116 Use instanceof with variable when possible

GitOrigin-RevId: ded3d92301a781752f9081405e8b01fa11f656a6

Author: Wohops

python-checks/src/main/java/org/sonar/python/checks/UselessStatementCheck.java

@@ -228,9 +228,9 @@ private void checkBinaryExpression(SubscriptionContext ctx) {
   }
 
   private static boolean couldBePython2PrintStatement(BinaryExpression binaryExpression) {
-    return TreeUtils.hasDescendant(binaryExpression, t -> t.is(Kind.CALL_EXPR)
-      && ((CallExpression) t).callee().is(Kind.NAME)
-      && "print".equals(((Name) ((CallExpression) t).callee()).name()));
+    return TreeUtils.hasDescendant(binaryExpression, t -> t instanceof CallExpression callExpression
+      && callExpression.callee() instanceof Name name
+      && "print".equals(name.name()));
   }
 
   private void checkUnaryExpression(SubscriptionContext ctx) {

python-checks/src/main/java/org/sonar/python/checks/XMLParserXXEVulnerableCheck.java

@@ -163,10 +163,8 @@ private static boolean checkSettingFeatureGesToTrue(CallExpression callExpressio
   }
 
   private static boolean isCallToSetFeature(CallExpression callExpression) {
-    if (!callExpression.callee().is(Tree.Kind.QUALIFIED_EXPR)) {
-      return false;
-    }
-    QualifiedExpression callee = (QualifiedExpression) callExpression.callee();
-    return callee.qualifier().is(Tree.Kind.NAME) && "setFeature".equals(callee.name().name());
+    return callExpression.callee() instanceof QualifiedExpression callee
+      && callee.qualifier().is(Tree.Kind.NAME)
+      && "setFeature".equals(callee.name().name());
   }
 }

python-checks/src/main/java/org/sonar/python/checks/hotspots/CorsCheck.java

@@ -119,8 +119,8 @@ private static void checkDjangoSettings(SubscriptionContext ctx) {
     AssignmentStatement assignment = (AssignmentStatement) ctx.syntaxNode();
 
     if (isVarAssignment(assignment, DJANGO_ALLOW_ALL)
-      && assignment.assignedValue().is(NAME)
-      && "True".equals(((Name) assignment.assignedValue()).name())) {
+      && assignment.assignedValue() instanceof Name name
+      && "True".equals(name.name())) {
       ctx.addIssue(assignment, MESSAGE);
 
     } else if (isVarAssignment(assignment, DJANGO_WHITELIST)) {

python-checks/src/main/java/org/sonar/python/checks/tests/AssertAfterRaiseCheck.java

@@ -107,8 +107,8 @@ public boolean isValidUnittestRaise(CallExpression callExpression) {
       .filter(call -> call.callee().is(Tree.Kind.QUALIFIED_EXPR))
       .map(call -> (QualifiedExpression) call.callee())
       .anyMatch(
-        callee -> callee.qualifier().is(Tree.Kind.NAME)
-        && "self".equals(((Name) callee.qualifier()).name())
+        callee -> callee.qualifier() instanceof Name qualifier
+        && "self".equals(qualifier.name())
         && UnittestUtils.RAISE_METHODS.contains(callee.name().name()))
       && isNotAssertionErrorArgument(TreeUtils.nthArgumentOrKeyword(0, UNITTEST_ARG_EXCEPTION, callExpression.arguments()));
   }
@@ -140,7 +140,7 @@ public boolean isAnAssert(Statement statement) {
   }
 
   public boolean isUnittestAssert(QualifiedExpression callee) {
-    return callee.qualifier().is(Tree.Kind.NAME) && "self".equals(((Name) callee.qualifier()).name())
+    return callee.qualifier() instanceof Name qualifier && "self".equals(qualifier.name())
        && UnittestUtils.allAssertMethods().contains(callee.name().name());
   }
 }

python-checks/src/main/java/org/sonar/python/checks/tests/AssertOnDissimilarTypesCheck.java

@@ -59,7 +59,7 @@ public void initialize(Context context) {
       }
 
       QualifiedExpression qualifiedExpression = (QualifiedExpression) callExpression.callee();
-      if ((!(qualifiedExpression.qualifier().is(Tree.Kind.NAME) && "self".equals(((Name) qualifiedExpression.qualifier()).name())))
+      if (!(qualifiedExpression.qualifier() instanceof Name qualifier && "self".equals(qualifier.name()))
        || !UnittestUtils.isWithinUnittestTestCase(qualifiedExpression)) {
         return;
       }