llvm: install software-properties-common on non-trixie suites (1.1.1)

llvm.sh requires add-apt-repository on Ubuntu noble and older Debian
suites; preinstall software-properties-common unless running on
trixie/forky/sid where it's gone and the deb822 path is used instead.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: chapterjason

src/llvm/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
   "id": "llvm",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "name": "llvm",
   "description": "Installs LLVM / Clang on Debian / Ubuntu via the official apt.llvm.org repository. Major-version binaries (clang, clang++, lld, lldb, clangd, clang-format, clang-tidy, etc.) are symlinked into /usr/local/bin without the version suffix.",
   "documentationURL": "https://github.com/SoureCode/devcontainer-features/tree/master/src/llvm",

src/llvm/install.sh

@@ -7,11 +7,17 @@ LLVM_VERSION="${VERSION:-22}"
 LLVM_ALL="${ALL:-true}"
 
 # llvm.sh writes the LLVM apt source in deb822 format on trixie/forky/sid, so
-# software-properties-common (gone from trixie) is no longer required. Older
-# Debian/Ubuntu suites still need add-apt-repository — install it on demand
-# when llvm.sh asks for it. Only install what's missing.
+# software-properties-common (gone from trixie) is no longer required there.
+# Older Debian/Ubuntu suites still need add-apt-repository, which lives in
+# software-properties-common. Detect the suite and preinstall accordingly.
+PKGS=(ca-certificates curl gnupg lsb-release wget)
+. /etc/os-release
+case "${VERSION_CODENAME:-}" in
+  trixie|forky|sid) ;;
+  *) PKGS+=(software-properties-common) ;;
+esac
 NEED=()
-for pkg in ca-certificates curl gnupg lsb-release wget; do
+for pkg in "${PKGS[@]}"; do
   dpkg -s "$pkg" >/dev/null 2>&1 || NEED+=("$pkg")
 done
 if [ "${#NEED[@]}" -gt 0 ]; then