Skip to content

Commit 2cf448e

Browse files
chapterjasonclaude
andcommitted
Drop the ESM entry smoke test
It stubbed HTMLElement and customElements on globalThis, then imported the bundle in Node. The module is a browser web component — importing it in Node is outside its contract, and the stubs were the kind of monkey patch this repo doesn't want. The typecheck, build:lib, dist artifact check, and npm pack dry-run together already validate the API surface and packaging. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent de09df7 commit 2cf448e

1 file changed

Lines changed: 0 additions & 12 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,6 @@ jobs:
3232
test -f dist/virtual-keyboard.js
3333
test -f dist/virtual-keyboard.d.ts
3434
35-
- name: Smoke test ESM entry
36-
run: |
37-
node -e '
38-
globalThis.HTMLElement = class {};
39-
globalThis.customElements = { define() {} };
40-
import("./dist/virtual-keyboard.js").then(m => {
41-
const keys = Object.keys(m);
42-
console.log("exports:", keys);
43-
const missing = ["VirtualKeyboard","terminalAdapter","nativeAdapter"].filter(k => !keys.includes(k));
44-
if (missing.length) { console.error("missing:", missing); process.exit(1); }
45-
})'
46-
4735
- name: Smoke test npm pack
4836
run: npm pack --dry-run
4937

0 commit comments

Comments
 (0)