Skip to content

🌱 Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye - #314

Merged
garloff merged 2 commits into
mainfrom
fix/dockerfile-build-go-version
Sep 22, 2025
Merged

🌱 Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye#314
garloff merged 2 commits into
mainfrom
fix/dockerfile-build-go-version

Conversation

@matofeder

@matofeder matofeder commented Sep 22, 2025

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Fixes CSO-0.2 img build failure: https://github.com/SovereignCloudStack/cluster-stack-operator/actions/runs/17912013752/job/50929794430

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

…lseye

Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
@matofeder
matofeder force-pushed the fix/dockerfile-build-go-version branch from d7c84e1 to 1810b61 Compare September 22, 2025 13:21
@matofeder matofeder changed the title Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye 🌱 Bump golang version in build image from 1.23.5-bullseye to 1.24.6-bullseye Sep 22, 2025

@jschoone jschoone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I tried the 1.24.6 locally but ended with the error. But now it seems to work, see https://github.com/SovereignCloudStack/cluster-stack-operator/actions/runs/17917369231
I added some suggestions to get rid of the warnings

Comment thread images/cso/Dockerfile Outdated
Comment thread images/cso/Dockerfile Outdated
Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Kurt Garloff <kurt@garloff.de>

@garloff garloff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Whether that is the complete solution needs to be seen, but certainly nothing wrong with this change.

@garloff
garloff requested a review from jschoone September 22, 2025 16:19
@garloff
garloff merged commit f1cd90a into main Sep 22, 2025
8 checks passed
@garloff
garloff deleted the fix/dockerfile-build-go-version branch September 22, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants