Skip to content

Commit f12c524

Browse files
committed
Infra/Tests/Other: 🌱: don't run make targets on pull_request_target
* although the rule `if: github.event_name != 'pull_request_target'` makes sure to not run the pr-lint steps on pull_request_target, we should not use this event trigger, but actually use `pull_request` instead * https://docs.github.com/en/actions/reference/security/securely-using-pull_request_target Signed-off-by: Jan Klare <klare@osism.tech>
1 parent 66dc97a commit f12c524

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎.github/workflows/pr-lint.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: "Lint Pull Request"
22
on: # yamllint disable-line rule:truthy
33
workflow_dispatch:
4-
pull_request_target:
4+
pull_request:
55
types: [opened, edited, synchronize, reopened, ready_for_review]
66
paths:
77
- "**.go"
@@ -16,7 +16,7 @@ on: # yamllint disable-line rule:truthy
1616
jobs:
1717
pr-lint:
1818
name: "Lint Pull Request"
19-
if: github.event_name != 'pull_request_target' || !github.event.pull_request.draft
19+
if: !github.event.pull_request.draft
2020
runs-on: ubuntu-latest
2121
container:
2222
image: ghcr.io/sovereigncloudstack/csctl-builder:0.2.3

0 commit comments

Comments
 (0)