Potential fix for code scanning alert no. 1: Workflow does not contain permissions - #334
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
marked this pull request as ready for review
November 28, 2025 12:07
mbuechse
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SovereignCloudStack/docs/security/code-scanning/1
The problem is that the workflow does not explicitly specify its permissions, allowing the GITHUB_TOKEN to inherit potentially excessive permissions. To fix this, the workflow should declare a minimum set of permissions. In this case, since the job only checks out code and runs a link checker (which does not modify repository contents, issues, or PRs), it should be sufficient to set
contents: readat either the workflow or the job level.As shown, the workflow contains only a single job, so it is simpler to add the
permissionsblock at the root level (top of the file, immediately after thename:), which will apply the permissions to all jobs unless overridden. No additional imports or dependencies are needed.Edit
.github/workflows/link-validator.ymlas follows:permissions:key (right below thename:and abovejobs:) with{contents: read}.Suggested fixes powered by Copilot Autofix. Review carefully before merging.