Potential fix for code scanning alert no. 3: Workflow does not contain permissions - #338
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
added
bug
garloff
marked this pull request as ready for review
December 2, 2025 18:57
mbuechse
approved these changes
Dec 3, 2025
mbuechse
left a comment
mbuechse
left a comment
Contributor
There was a problem hiding this comment.
See the other PR. I'm not sure, but we can always repair later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SovereignCloudStack/docs/security/code-scanning/3
The best way to fix this issue is to explicitly set the
permissionsblock at the job or workflow level (directly undername:at the root, or within the specific job). For this workflow, since only thecontents: writepermission is needed for publishing viapeaceiris/actions-gh-pages@v3, we can setcontents: writeat the job level forbuild_and_staging. This ensures that the GITHUB_TOKEN has only the permissions necessary to complete the operations (i.e., pushing to the gh-pages-staging branch) and no more. The change should be made by adding the following lines just beforeruns-on: ubuntu-latest(line 11), indented properly as per YAML requirements.Suggested fixes powered by Copilot Autofix. Review carefully before merging.