Skip to content

Commit 49c7bb0

Browse files
authored
Revise scs-0214-v2: remove nonsensical regulation (#1163)
Closes #1152 Also: retire k8s_version_policy_test.py Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
1 parent 4f0f381 commit 49c7bb0

6 files changed

Lines changed: 10 additions & 13 deletions

File tree

Standards/scs-0214-v2-k8s-node-distribution.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ to provide a fault-tolerant and available Kubernetes cluster infrastructure.
6969

7070
The control plane nodes MUST be distributed over multiple physical machines.
7171
Kubernetes provides [best-practices][k8s-zones] on this topic, which are also RECOMMENDED by SCS.
72-
73-
At least one control plane instance MUST be run in each "failure zone" used for the cluster,
74-
more instances per "failure zone" are possible to provide fault-tolerance inside a zone.
72+
In particular, the control plane nodes SHOULD be distributed over multiple failure zones.
7573

7674
Worker nodes are RECOMMENDED to be distributed over multiple zones. This policy makes
7775
it OPTIONAL to provide a worker node in each "failure zone", meaning that worker nodes

Standards/scs-0214-w1-k8s-node-distribution-implementation-testing.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,12 @@ Node distribution metadata is provided through the usage of the labels
2020
## Automated tests
2121

2222
Currently, automated testing is not readily possible because we cannot access information about
23-
the underlying host of a node (as opposed to its region and zone). Therefore, the test will only output
24-
a tentative result.
23+
the underlying host of a node (as opposed to its region and zone). Besides, access to
24+
control-plane nodes is problematic outside of a kubeadm-based setup.
2525

26-
The current implementation can be found in the script [`k8s_node_distribution_check.py`](https://github.com/SovereignCloudStack/standards/blob/main/Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py).
26+
Therefore, no automated tests are performed at this time.
2727

2828
## Manual tests
2929

30-
None.
30+
Cloud-service providers must confirm that control plane nodes are indeed distributed over
31+
multiple physical machines.

Tests/kaas/k8s-node-distribution/check_nodes_test.py renamed to Tests/kaas/scs_0214_node_distribution_RETIRED/check_nodes_test.py

File renamed without changes.

Tests/kaas/k8s-node-distribution/k8s_node_distribution_check.py renamed to Tests/kaas/scs_0214_node_distribution_RETIRED/k8s_node_distribution_check.py

File renamed without changes.

Tests/kaas/k8s-node-distribution/testdata/scenarios.yaml renamed to Tests/kaas/scs_0214_node_distribution_RETIRED/testdata/scenarios.yaml

File renamed without changes.

Tests/scs-compatible-kaas.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,10 @@ scripts:
2727
section: light
2828
description: Must fulfill all requirements of scs-0210-v2.
2929
url: https://docs.scs.community/standards/scs-0210-v2-k8s-version-policy#decision
30-
- executable: ./kaas/k8s-node-distribution/k8s_node_distribution_check.py
31-
args: -k {kubeconfig}
32-
testcases:
30+
- testcases:
3331
- id: node-distribution-check
34-
section: light
35-
description: Must fulfill all requirements of scs-0214-v2.
32+
description: >-
33+
Manual check: Must fulfill all requirements of scs-0214-v2.
3634
url: https://docs.scs.community/standards/scs-0214-v2-k8s-node-distribution#decision
3735
- executable: ./kaas/sonobuoy_handler/run_sonobuoy.py
3836
args: run -k {kubeconfig} --scs-sonobuoy-config kaas/scs-sonobuoy-config-v1.yaml -r {subject_root}/sono-results-0219 -c 'kaas-networking-check' -a '--e2e-focus "NetworkPolicy"' --execution-mode {execution_mode}
@@ -60,7 +58,7 @@ modules:
6058
name: Kubernetes node distribution and availability
6159
url: https://docs.scs.community/standards/scs-0214-v2-k8s-node-distribution
6260
targets:
63-
main:
61+
preview:
6462
- node-distribution-check
6563
- id: scs-0219-v1
6664
name: KaaS networking

0 commit comments

Comments
 (0)