Drop redundant copy of checkout, run in pod (#750)

Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>

Author: mbuechse

.zuul.d/config.yaml

@@ -18,6 +18,7 @@
 - job:
     name: scs-check-adr-syntax
     parent: base
+    nodeset: pod-fedora-40
     pre-run: playbooks/pre.yaml
     run: playbooks/adr_syntax.yaml
 - job:
@@ -26,6 +27,7 @@
     secrets:
      - name: clouds_conf
        secret: SECRET_STANDARDS
+    nodeset: pod-fedora-40
     vars:
       preset: default
     pre-run:

playbooks/adr_syntax.yaml

@@ -3,15 +3,17 @@
   hosts: all
   tasks:
     - name: Run ADR syntax check script
-      ansible.builtin.shell: |
-        python3 ~/Tests/chk_adrs.py ~/Standards
+      ansible.builtin.command:
+        cmd: python3 Tests/chk_adrs.py Standards
+        chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
       register: result
       changed_when: true
       failed_when: result.rc != 0
 
     - name: Run test script consistency check script
-      ansible.builtin.shell: |
-        python3 ~/Tests/iaas/flavor-naming/check_yaml.py ~/Tests/iaas
+      ansible.builtin.shell:
+        cmd: python3 Tests/iaas/flavor-naming/check_yaml.py Tests/iaas
+        chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
       register: result
       changed_when: true
       failed_when: result.rc != 0

playbooks/compliance_check.yaml

@@ -3,15 +3,16 @@
   hosts: all
   tasks:
     - name: Run compliance script
-      ansible.builtin.shell: >
-        python3 ~/Tests/scs-test-runner.py --config ~/Tests/config.toml --debug run --preset {{ preset }} --output report.yaml
+      ansible.builtin.command:
+        cmd: python3 Tests/scs-test-runner.py --config Tests/config.toml --debug run --preset {{ preset }} --output report.yaml
+        chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
       changed_when: true
 
     - name: Copy result YAML
       ansible.builtin.synchronize:
         dest: "{{ zuul.executor.log_root }}/report.yaml"
         mode: pull
-        src: "report.yaml"
+        src: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}/report.yaml"
         verify_host: true
         owner: no
         group: no

playbooks/pre.yaml

@@ -4,20 +4,7 @@
   roles:
     - role: ensure-pip  # https://zuul-ci.org/docs/zuul-jobs/latest/python-roles.html#role-ensure-pip
   tasks:
-    - name: Copy ADRs on the node
-      ansible.builtin.copy:
-        src: "../Standards"
-        dest: "~/"
-        mode: 0500
-      no_log: false
-
-    - name: Copy Tests on the node
-      ansible.builtin.copy:
-        src: "../Tests"
-        dest: "~/"
-        mode: 0500
-      no_log: false
-
     - name: Install dependencies
       ansible.builtin.pip:
-        requirements: ~/Tests/requirements.txt
+        chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
+        requirements: "Tests/requirements.txt"

playbooks/pre_cloud.yaml

@@ -2,7 +2,6 @@
 - name: Prepare cloud config and ensure clean env
   hosts: all
   roles:
-    - role: ensure-pip  # https://zuul-ci.org/docs/zuul-jobs/latest/python-roles.html#role-ensure-pip
     - role: bindep # https://zuul-ci.org/docs/zuul-jobs/latest/general-roles.html#role-bindep
   tasks:
     - name: Create cloud config dir
@@ -21,7 +20,7 @@
 
     - name: Create secrets dir
       ansible.builtin.file:
-        path: "~/Tests/.secret"
+        path: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}/Tests/.secret"
         state: directory
         recurse: true
         mode: "0700"
@@ -30,18 +29,19 @@
       ansible.builtin.copy:
         # the secrets are usually stripped of whitespace, but the final newline is essential here
         content: "{{ clouds_conf.zuul_ci_signing_key + '\n' }}"
-        dest: "~/Tests/.secret/keyfile"
+        dest: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}/Tests/.secret/keyfile"
         mode: "0600"
       no_log: true
 
     - name: Create basic_auth token file
       ansible.builtin.copy:
         content: "{{ clouds_conf.zuul_ci_basic_auth }}"
-        dest: "~/Tests/.secret/tokenfile"
+        dest: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}/Tests/.secret/tokenfile"
         mode: "0600"
       no_log: true
 
     - name: Clean up any lingering resources from previous run
-      ansible.builtin.shell: >
-        python3 ~/Tests/scs-test-runner.py --config ~/Tests/config.toml --debug cleanup --preset {{ preset }}
+      ansible.builtin.command:
+        cmd: python3 Tests/scs-test-runner.py --config Tests/config.toml --debug cleanup --preset {{ preset }}
+        chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
       changed_when: true