@@ -73,7 +73,7 @@ def compute_scs_0101_image_property(images, attributes=IMAGE_ATTRIBUTES):
7373 # drop those candidates that are fine
7474 offenders = [candidate for candidate in candidates if candidate [1 ]]
7575 for name , wrong in offenders :
76- logger .error (f"Image '{ name } ' missing recommended attributes: { ', ' .join (wrong )} " )
76+ logger .error (f"Image '{ name } ' missing attributes: { ', ' .join (wrong )} " )
7777 return not offenders
7878
7979
@@ -86,10 +86,10 @@ def compute_scs_0101_flavor_property(flavors, attributes=FLAVOR_ATTRIBUTES, opti
8686 miss_opt = [key for key in optional if extra_specs .get (key ) is None ]
8787 if wrong :
8888 offenses += 1
89- message = f"Flavor '{ flavor .name } ' missing recommended attributes: { ', ' .join (wrong )} "
90- # only report missing optional attributes if recommended are missing as well
89+ message = f"Flavor '{ flavor .name } ' missing attributes: { ', ' .join (wrong )} "
90+ # only report missing optional attributes if main ones are missing as well
9191 # reasoning here is that these optional attributes are merely a hint for implementers
92- # and if the recommended attributes are present, we assume that implementers have done their job already
92+ # and if the main ones are present, we assume that implementers have done their job already
9393 if miss_opt :
9494 message += f"; additionally, missing optional attributes: { ', ' .join (miss_opt )} "
9595 logger .error (message )
@@ -113,7 +113,7 @@ def compute_scs_0101_rngd(collected_vm_output, image_name):
113113 """This test ensures that the `rngd` service is running on a test VM."""
114114 lines = collected_vm_output ['rngd' ]
115115 if "could not be found" in '\n ' .join (lines ):
116- logger .error (f"VM '{ image_name } ' doesn't provide the recommended service rngd" )
116+ logger .error (f"VM '{ image_name } ' doesn't provide service rngd" )
117117 return False
118118 return True
119119
@@ -158,7 +158,7 @@ def compute_scs_0101_virtio_rng(collected_vm_output, image_name):
158158 return False
159159 return True
160160 except BaseException :
161- logger .critical (f"Couldn't check VM '{ image_name } ' recommends " , exc_info = True )
161+ logger .critical (f"Couldn't check VM '{ image_name } ' properties " , exc_info = True )
162162
163163
164164class TestEnvironment :
0 commit comments