compile regex first.

Author: guettli

Tests/kaas/sonobuoy_handler/sonobuoy_handler.py

@@ -103,8 +103,9 @@ def _sonobuoy_retrieve_result(self, plugin='e2e'):
         self._invoke_sonobuoy("retrieve", "-x", result_dir)
         yaml_path = os.path.join(result_dir, 'plugins', plugin, 'sonobuoy_results.yaml')
         logger.debug(f"parsing results from {yaml_path}")
+        ok_to_fail_regex_list = _load_ok_to_fail_regex_list(self.scs_sonobuoy_config_yaml)
 
-        return sonobuoy_parse_result(plugin, yaml_path, self.scs_sonobuoy_config_yaml)
+        return sonobuoy_parse_result(plugin, yaml_path, ok_to_fail_regex_list)
 
     def run(self):
         """
@@ -125,8 +126,7 @@ def run(self):
             self._sonobuoy_delete()
 
 
-def sonobuoy_parse_result(plugin, sonobuoy_results_yaml_path, scs_sonobuoy_config_yaml):
-    ok_to_fail_regex_list = _load_ok_to_fail_regex_list(scs_sonobuoy_config_yaml)
+def sonobuoy_parse_result(plugin, sonobuoy_results_yaml_path, ok_to_fail_regex_list):
     with open(sonobuoy_results_yaml_path, "r") as fileobj:
         result_obj = yaml.load(fileobj.read(), yaml.SafeLoader)
 
@@ -186,7 +186,7 @@ def _load_ok_to_fail_regex_list(scs_sonobuoy_config_yaml):
             raise ValueError(
                 f"Invalid sonobuoy config format in {scs_sonobuoy_config_yaml}: okToFail[{idx}].reason must be a non-empty string"
             )
-        ok_to_fail_regex_list.append((regex, reason))
+        ok_to_fail_regex_list.append((re.compile(regex), reason))
     return ok_to_fail_regex_list
 
 
@@ -199,6 +199,7 @@ def ok_to_fail(ok_to_fail_regex_list, test_name):
 
 
 def check_sonobuoy_result(scs_sonobuoy_config_yaml, result_yaml):
-    counter = sonobuoy_parse_result("", result_yaml, scs_sonobuoy_config_yaml)
+    ok_to_fail_regex_list = _load_ok_to_fail_regex_list(scs_sonobuoy_config_yaml)
+    counter = sonobuoy_parse_result("", result_yaml, ok_to_fail_regex_list)
     for key, value in counter.items():
         print(f"{key}: {value}")