Skip to content

Avoid CPU:Mem which confuses some markdown parsers. - #1023

Merged
mbuechse merged 7 commits into
mainfrom
feat/flavor-mem-md-syntax
Dec 3, 2025
Merged

Avoid CPU:Mem which confuses some markdown parsers.#1023
mbuechse merged 7 commits into
mainfrom
feat/flavor-mem-md-syntax

Conversation

@garloff

@garloff garloff commented Nov 27, 2025

Copy link
Copy Markdown
Member

Cosmetic ...

@garloff
Avoid CPU:Mem which confuses some markdown parsers.
59f92c1 
Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff garloff self-assigned this Nov 27, 2025
@garloff garloff added bug Something isn't working work in progress Pull requests that are work in progress, do not merge them standards Issues / ADR / pull requests relevant for standardization & certification labels Nov 27, 2025
depressiveRobot
depressiveRobot requested changes Nov 27, 2025
View reviewed changes

@depressiveRobot depressiveRobot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a general problem? As there are many other places like "CPU:Mem" or "1:4". For example see scs-0100-v1-flavor-naming.md

Comment thread Standards/scs-0100-v1-flavor-naming.md
mbuechse
mbuechse reviewed Nov 27, 2025
View reviewed changes

@mbuechse mbuechse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would apply the same change to https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0103-v1-standard-flavors.md?plain=1#L135
I can do it (but I don't know when).

@garloff

garloff commented Nov 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I would apply the same change to https://github.com/SovereignCloudStack/standards/blob/main/Standards/scs-0103-v1-standard-flavors.md?plain=1#L135 I can do it (but I don't know when).

True, thanks for spotting! Done in @b105c8d.

mbuechse
mbuechse approved these changes Nov 28, 2025
View reviewed changes

@mbuechse mbuechse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docusaurus is good for surprises. Thanks for resolving this!

@garloff
Fix link to flavor-name-check.py script.
f05d17b 
Otherwise our CI will complain. Rightly so.

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff
Merge branch 'main' into feat/flavor-mem-md-syntax
3ede045
@garloff

garloff commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

@depressiveRobot: Did I address your concerns? If so, please re-review (and approve).

depressiveRobot
depressiveRobot approved these changes Dec 3, 2025
View reviewed changes

@depressiveRobot depressiveRobot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have passed. Looks good now to me :)

@mbuechse
mbuechse merged commit d975b38 into main Dec 3, 2025
10 checks passed
@mbuechse
mbuechse deleted the feat/flavor-mem-md-syntax branch December 3, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbuechse mbuechse mbuechse approved these changes
@depressiveRobot depressiveRobot depressiveRobot approved these changes
@fkr fkr Awaiting requested review from fkr fkr is a code owner

Assignees

@garloff garloff

Labels

bug Something isn't working standards Issues / ADR / pull requests relevant for standardization & certification work in progress Pull requests that are work in progress, do not merge them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garloff @depressiveRobot @mbuechse