Skip to content

Replace kaas subject placeholders in compliance overview - #1173

Merged
fkr merged 3 commits into
mainfrom
fix/fix-noris-spelling
May 22, 2026
Merged

Replace kaas subject placeholders in compliance overview#1173
fkr merged 3 commits into
mainfrom
fix/fix-noris-spelling

Conversation

@fkr

@fkr fkr commented May 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@mbuechse mbuechse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name and the url were meant as placeholders anyway. I'm not opposed to this fix, but I think something more specific would be in order!

@fkr

fkr commented May 19, 2026

Copy link
Copy Markdown
Member Author

@benedikt-haug please provide something more specific, if need be :)

@fkr
fkr requested a review from benedikt-haug May 19, 2026 07:48
Comment thread compliance-monitor/templates/overview.md.j2 Outdated
Comment thread compliance-monitor/templates/overview.md.j2 Outdated
@mbuechse mbuechse changed the title correct spelling. It is 'noris', not 'Noris'. Replace kaas subject placeholders in compliance overview May 19, 2026
@mbuechse
mbuechse force-pushed the fix/fix-noris-spelling branch from 5519144 to b0c0607 Compare May 19, 2026 14:12
@mbuechse

Copy link
Copy Markdown
Contributor

Github UI is still fudging up my commit e-mail. They used to show which e-mail would be used, but even that's gone.

@mbuechse
mbuechse force-pushed the fix/fix-noris-spelling branch from b0c0607 to 75e3dd5 Compare May 19, 2026 14:14
@mbuechse
mbuechse requested a review from janiskemper May 19, 2026 14:16
@fkr

fkr commented May 20, 2026

Copy link
Copy Markdown
Member Author

For the noris part, the OK came via e-mail.

@mbuechse
mbuechse marked this pull request as draft May 20, 2026 15:18
@mbuechse

Copy link
Copy Markdown
Contributor

For the noris part, the OK came via e-mail.

Please incorporate the open change before merging.

@fkr

fkr commented May 20, 2026

Copy link
Copy Markdown
Member Author

and for the Syself part the review from @janiskemper is still missing (at least the github mobile app suggests this)

@mbuechse

Copy link
Copy Markdown
Contributor

@fkr I put what he told me via Matrix, but I'm open to waiting for his formal approval

@mbuechse
mbuechse marked this pull request as ready for review May 20, 2026 15:52
fkr and others added 3 commits May 22, 2026 09:43
Signed-off-by: Felix Kronlage-Dammers <fkr@hazardous.org>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Co-authored-by: Marvin Frommhold <depressiveRobot@users.noreply.github.com>
Signed-off-by: Felix Kronlage-Dammers <fkr@hazardous.org>
@fkr
fkr force-pushed the fix/fix-noris-spelling branch from 54d9ad1 to cba08a0 Compare May 22, 2026 07:43
@fkr
fkr merged commit 9b150b5 into main May 22, 2026
7 checks passed
@fkr
fkr deleted the fix/fix-noris-spelling branch May 22, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants