Skip to content

Fix db bootstrap logic #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbuechse merged 1 commit into from
Jun 2, 2026
Merged

Fix db bootstrap logic #1180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions compliance-monitor/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,13 @@ def db_upgrade_schema(conn: connection, cur: cursor):
# that way just in case we want to use another database at some point
while True:
current = db_get_schema_version(cur)
if current >= SCHEMA_VERSIONS[-1]: # bail if version is too new (but hope it's compatible)
break
if current is None:
# this is an empty db, but it also used to be the case with v1
# I (mbuechse) made sure manually that the value v1 is set on running installations
db_ensure_schema_v4(cur)
db_set_schema_version(cur, 'v4')
conn.commit()
break # Nothing more to do, we bootstrapped with the latest schema version
elif current == 'v1':
db_ensure_schema_v2(cur)
db_upgrade_data_v1_v2(cur)
Expand All @@ -219,6 +218,8 @@ def db_upgrade_schema(conn: connection, cur: cursor):
db_ensure_schema_v4(cur)
db_set_schema_version(cur, 'v4')
conn.commit()
elif current >= SCHEMA_VERSIONS[-1]: # bail if version is too new (but hope it's compatible)
break


def db_ensure_schema(conn: connection):
Expand Down
Loading