Fix k8s_version_policy.py to log on stderr (instead of stdout) - #1208
Merged
Conversation
Contributor
Author
|
Result of version policy check cannot be seen on (This will change once again with #1073 or so, but for now, this fix is good.) |
depressiveRobot
approved these changes
Jun 16, 2026
depressiveRobot
left a comment
Contributor
There was a problem hiding this comment.
Really a small change, so this is fine.
However, I still don't quite understand it. Do you mean that in the redacted state, the reason why the test fails cannot be seen?
Contributor
Author
|
Yes, in the redacted state, only lines starting with ERROR or WARNING on stderr are shown. Also, no one would expect them in stdout, even if they were shown. |
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
mbuechse
force-pushed
the
fix/scs-210-test-output
branch
from
June 16, 2026 14:06
c8b8041 to
b04ccf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.