Nested visible frame inset fix#119

Open

casperzandbergenyaacomm wants to merge 7 commits into

SoySauceLab:masterfrom

casperzandbergenyaacomm:nested-visibleFrameInset-fix

Commits on Nov 28, 2018

`visibleIndexes(visibleFrame:)` is now `visible(for:)` and returns both the visible indexes and the frame they appear in. This frame can be different from the input frame if the layout changes it (…

Casper Zandbergen
authored and
Casper Zandbergen
committed
Fixed the bug where headers were not shown on top. The issue was fixed by taking the order of indexes returned by the layout into account. This does add two filters when `visible(for:)` is called o…

Casper Zandbergen
authored and
Casper Zandbergen
committed

Commits on Nov 30, 2018

transpose layout returns the frame in the original state, not transposed.

Casper Zandbergen
authored and
Casper Zandbergen
committed
Changed to an intersection to an overlap calculation that still returns a rect for the section to add its visible frame inset to.

Casper Zandbergen
authored and
Casper Zandbergen
committed
Fix for horizontal layout inside section provider with vertical layout (or the other way around). After this fix there is one more issue:

Casper Zandbergen
authored and
Casper Zandbergen
committed
Added comment for unexpected behaviour, we can't actually check if the insets are in the right direction because the VisibleFrameInsetLayout might get transposed later.

Casper Zandbergen
authored and
Casper Zandbergen
committed
visible(for:) to visible(in:) better english
casperzandbergenyaacomm
committed