fix(query/v2): require relationship shortest paths

Author: zinic

query/v2/query.go

@@ -1150,6 +1150,10 @@ func (s *builder) hasActions() bool {
 	return len(s.projections) > 0 || len(s.setItems) > 0 || len(s.removeItems) > 0 || len(s.creates) > 0 || len(s.deleteItems) > 0
 }
 
+func (s *builder) wantsShortestPathPattern() bool {
+	return s.shortestPathQuery || s.allShorestPathsQuery
+}
+
 func (s *builder) Build() (*PreparedQuery, error) {
 	if len(s.errors) > 0 {
 		return nil, errors.Join(s.errors...)
@@ -1232,6 +1236,10 @@ func (s *builder) Build() (*PreparedQuery, error) {
 	matchIdentifiers := readIdentifiers.Clone()
 	matchIdentifiers.Or(actionIdentifiers)
 
+	if s.wantsShortestPathPattern() && !isRelationshipPattern(matchIdentifiers, s.identifiers) {
+		return nil, fmt.Errorf("shortest path query requires relationship query identifiers")
+	}
+
 	if len(s.constraints) > 0 || matchIdentifiers.Len() > 0 {
 		if isNodePattern(matchIdentifiers, s.identifiers) {
 			if err := prepareNodePattern(match, matchIdentifiers, s.identifiers); err != nil {

query/v2/query_test.go

@@ -238,6 +238,12 @@ func TestShortestPathControls(t *testing.T) {
 		v2.Path(),
 	).Build()
 	require.ErrorContains(t, err, "query is requesting both all shortest paths and shortest paths")
+
+	_, err = v2.New().WithShortestPaths().Return(v2.Node()).Build()
+	require.ErrorContains(t, err, "shortest path query requires relationship query identifiers")
+
+	_, err = v2.New().WithAllShortestPaths().Return(v2.As(v2.Literal(1), "one")).Build()
+	require.ErrorContains(t, err, "shortest path query requires relationship query identifiers")
 }
 
 func TestMixedNodeAndRelationshipIdentifiersReturnError(t *testing.T) {