wip: test_adjacency_list

Author: SpectraL519

include/gl/edge_descriptor.hpp

@@ -49,6 +49,11 @@ class edge_descriptor final {
 
     ~edge_descriptor() = default;
 
+    // TODO: add tests
+    [[nodiscard]] bool operator==(const edge_descriptor& other) const noexcept {
+        return this->_id == other._id and this->_vertices == other._vertices;
+    }
+
     [[nodiscard]] constexpr bool is_directed() const noexcept {
         return type_traits::is_directed_v<type>;
     }

include/gl/impl/adjacency_list.hpp

@@ -10,6 +10,12 @@
 #include "gl/types/types.hpp"
 #include "specialized/adjacency_list.hpp"
 
+#ifdef GL_TESTING
+namespace gl_testing {
+struct test_adjacency_list;
+} // namespace gl_testing
+#endif
+
 namespace gl::impl {
 
 template <type_traits::c_list_graph_traits GraphTraits>
@@ -113,7 +119,7 @@ class adjacency_list final {
         });
         if (item_it == adjacent_edges.cend())
             return std::nullopt;
-        return std::make_optional<edge_type>(source_id, target_id);
+        return std::make_optional<edge_type>(item_it->id, source_id, target_id);
     }
 
     [[nodiscard]] std::optional<edge_type> get_edge(
@@ -181,6 +187,10 @@ class adjacency_list final {
                });
     }
 
+#ifdef GL_TESTING
+    friend struct gl_testing::test_adjacency_list;
+#endif
+
 private:
     using specialized_impl = typename specialized::list_impl_traits<adjacency_list>::type;
     friend specialized_impl;

include/gl/impl/specialized/adjacency_list.hpp

@@ -125,14 +125,14 @@ struct directed_adjacency_list {
             if (id == vertex_id or adj_edges.empty())
                 continue;
 
-            const auto rem_subrange = std::ranges::remove_if(
+            const auto removed_subrng = std::ranges::remove_if(
                 adj_edges, [vertex_id](const auto& item) { return item.target_id == vertex_id; }
             );
             std::ranges::copy(
-                rem_subrange | std::views::transform(&edge_list_item::id),
+                removed_subrng | std::views::transform(&edge_list_item::id),
                 std::back_inserter(removed_edges)
             );
-            adj_edges.erase(rem_subrange.begin(), rem_subrange.end());
+            adj_edges.erase(removed_subrng.begin(), removed_subrng.end());
         }
 
         // remove the list of edges incident from the vertex entirely
@@ -151,10 +151,10 @@ struct directed_adjacency_list {
             if (id == vertex_id or adj_edges.empty())
                 continue;
 
-            const auto rem_subrange = std::ranges::remove_if(
+            const auto removed_subrng = std::ranges::remove_if(
                 adj_edges, [vertex_id](const auto& item) { return item.target_id == vertex_id; }
             );
-            adj_edges.erase(rem_subrange.begin(), rem_subrange.end());
+            adj_edges.erase(removed_subrng.begin(), removed_subrng.end());
         }
 
         // remove the list of edges incident from the vertex entirely
@@ -246,11 +246,11 @@ struct undirected_adjacency_list {
                 continue; // will be removed with the vertex's list
 
             auto& adj_edges = self._list[item.target_id];
-            const auto rem_subrange =
+            const auto removed_subrng =
                 std::ranges::remove_if(adj_edges, [vertex_id](const auto& edge) {
                     return edge->is_incident_with(vertex_id);
                 });
-            adj_edges.erase(rem_subrange.begin(), rem_subrange.end());
+            adj_edges.erase(removed_subrng.begin(), removed_subrng.end());
         }
 
         // remove the list of edges incident from the vertex entirely

tests/include/testing/gl/transforms.hpp

@@ -6,12 +6,14 @@
 
 namespace gl_testing::transforms {
 
+// TODO: replace with generic get_id
 template <
     gl::type_traits::c_instantiation_of<gl::vertex_descriptor> VertexType = gl::vertex_descriptor<>>
 inline gl::types::id_type extract_vertex_id(const VertexType& vertex) {
     return vertex.id();
 }
 
+// TODO: remove
 template <typename T>
 struct address_projection {
     auto operator()(const T& ref) const {