wip: alignment

Author: SpectraL519

include/gl/topology/binary_tree.hpp

@@ -7,7 +7,7 @@
 #include "gl/constants.hpp"
 #include "gl/conversion.hpp"
 #include "gl/graph.hpp"
-#include "gl/util/pow.hpp"
+#include "gl/util/math.hpp"
 
 #include <initializer_list>
 

include/gl/util/pow.hpp include/gl/util/math.hppinclude/gl/util/pow.hpp renamed to include/gl/util/math.hpp

@@ -41,8 +41,16 @@ inline constexpr auto deref_view =
 
 // TODO: add tests
 
-/// @brief A generic view that concatenates two ranges/views.
-/// @todo Replace with `std::views::concat` (Requires C++26)
+/// @brief A view concatenating two ranges sequentially (C++20 polyfill for C++26 `std::views::concat`).
+///
+/// @warning **GCC 13/14 Bug:** Using branching views (like this or `std::ranges::filter_view`)
+/// inside complex algorithms (e.g., `std::ranges::is_permutation`) may trigger false-positive
+/// `-Wmaybe-uninitialized` warnings. To work around this, suppress the warning at the call site
+/// or materialize the view into a contiguous container like `std::vector`.
+///
+/// @tparam V1 First view type.
+/// @tparam V2 Second view type.
+/// @todo Replace with `std::views::concat` (C++26).
 template <std::ranges::view V1, std::ranges::view V2>
 class concat_view : public std::ranges::view_interface<concat_view<V1, V2>> {
 public:
@@ -179,8 +187,10 @@ struct concat_fn {
 
 } // namespace detail
 
-/// @brief Concatenates two ranges sequentially into a single view.
-/// @todo replace with `std::views::concat`
+/// @brief Concatenates two viewable ranges into a `concat_view`.
+/// @param r1 First range to concatenate.
+/// @param r2 Second range to concatenate.
+/// @todo Replace with `std::views::concat` (C++26).
 inline constexpr detail::concat_fn concat{};
 
 } // namespace gl::util

include/gl/util/ranges.hpp

@@ -1,6 +1,10 @@
-#include <gl/util/pow.hpp>
+#include "doctest.h"
 
-#include <doctest.h>
+#include <gl/util/math.hpp>
+#include <gl/util/ranges.hpp>
+
+#include <ranges>
+#include <vector>
 
 namespace gl_testing {
 

tests/source/gl/test_util.cpp

@@ -1231,9 +1231,10 @@ TEST_CASE_FIXTURE(
     const auto [tail_bound_hyperedges, head_bound_hyperedges] =
         altbind_to_vertex(sut, vertex_id, constants::n_hyperedges);
 
-    CHECK(std::ranges::is_permutation(
-        sut.incident_hyperedges(vertex_id), constants::hyperedge_ids_view
-    ));
+    // NOTE: An explicit allocation is needed because of the GCC's false positive -Wmaybe-uninitialized warning
+    const auto incident_hyperedges =
+        sut.incident_hyperedges(vertex_id) | std::ranges::to<std::vector>();
+    CHECK(std::ranges::is_permutation(incident_hyperedges, constants::hyperedge_ids_view));
     CHECK(std::ranges::equal(sut.out_hyperedges(vertex_id), tail_bound_hyperedges));
     CHECK(std::ranges::equal(sut.in_hyperedges(vertex_id), head_bound_hyperedges));
 }

tests/source/hgl/test_flat_incidence_list.cpp

@@ -1214,9 +1214,10 @@ TEST_CASE_FIXTURE(
     const auto [tail_bound_hyperedges, head_bound_hyperedges] =
         altbind_to_vertex(sut, vertex_id, constants::n_hyperedges);
 
-    CHECK(std::ranges::is_permutation(
-        sut.incident_hyperedges(vertex_id), constants::hyperedge_ids_view
-    ));
+    // NOTE: An explicit allocation is needed because of the GCC's false positive -Wmaybe-uninitialized warning
+    const auto incident_hyperedges =
+        sut.incident_hyperedges(vertex_id) | std::ranges::to<std::vector>();
+    CHECK(std::ranges::is_permutation(incident_hyperedges, constants::hyperedge_ids_view));
     CHECK(std::ranges::equal(sut.out_hyperedges(vertex_id), tail_bound_hyperedges));
     CHECK(std::ranges::equal(sut.in_hyperedges(vertex_id), head_bound_hyperedges));
 }