resolved comments

Author: SpectraL519

.clangd

@@ -8,6 +8,7 @@ CompileFlags:
     - -Wextra
     - -Wcast-align
     - -Wconversion
+    - -Wsign-conversion
     - -Wunreachable-code
     - -Wuninitialized
     - -Wunused

include/gl/graph.hpp

@@ -10,8 +10,6 @@
 #include "gl/io/stream_options_manipulator.hpp"
 #include "gl/util/ranges.hpp"
 
-#include <sys/types.h>
-
 #include <set>
 
 namespace gl {

include/gl/impl/specialized/adjacency_matrix.hpp

@@ -277,9 +277,10 @@ struct undirected_adjacency_matrix {
             | std::views::filter([](auto edge_id) { return edge_id != invalid_id; })
             | std::ranges::to<std::vector>();
 
-        self._matrix.erase(self._matrix.begin() + static_cast<std::ptrdiff_t>(vertex_id));
+        const auto vertex_pos = static_cast<std::ptrdiff_t>(vertex_id);
+        self._matrix.erase(self._matrix.begin() + vertex_pos);
         for (auto& row : self._matrix)
-            row.erase(row.begin() + static_cast<std::ptrdiff_t>(vertex_id));
+            row.erase(row.begin() + vertex_pos);
 
         return removed_edges;
     }

include/gl/impl/specialized/flat_adjacency_list.hpp

@@ -8,7 +8,6 @@
 #include "gl/decl/impl_tags.hpp"
 #include "gl/graph_traits.hpp"
 #include "gl/impl/specialized/adjacency_list.hpp"
-#include "gl/types/core.hpp"
 #include "gl/types/flat_jagged_vector.hpp"
 
 #include <algorithm>

include/hgl/impl/flat_incidence_list.hpp

@@ -495,12 +495,10 @@ class flat_incidence_list<hgl::bf_directed_t, ImplTag> final {
         const id_type id, const Projection storage_proj
     ) const noexcept {
         const auto idx = to_idx(id);
-        if constexpr (std::same_as<Projection, std::identity>) {
+        if constexpr (std::same_as<Projection, std::identity>)
             return util::concat(this->_tail_storage[idx], this->_head_storage[idx]);
-        }
-        else {
+        else
             return (this->*storage_proj)[idx];
-        }
     }
 
     template <element_type Element>

include/hgl/impl/incidence_matrix.hpp

@@ -4,7 +4,6 @@
 
 #pragma once
 
-#include "gl/types/core.hpp"
 #include "hgl/constants.hpp"
 #include "hgl/decl/impl_tags.hpp"
 #include "hgl/directional_tags.hpp"

tests/source/gl/test_graph.cpp

@@ -83,20 +83,23 @@ struct test_graph {
         validate_full_graph_edges(graph);
     }
 
+    // clang-format off
+
     template <gl::traits::c_instantiation_of<gl::graph> GraphType>
     void validate_full_graph_edges(const GraphType& graph) {
         REQUIRE(std::ranges::all_of(
             graph.vertex_ids(),
             [&graph, expected_n_edges = n_incident_edges_for_fully_connected_vertex(graph)](
                 const gl::default_id_type vertex_id
             ) {
-                return static_cast<std::size_t>(gl::util::range_size(graph.adjacent_edges(vertex_id)
-                       ))
+                return static_cast<std::size_t>(gl::util::range_size(graph.adjacent_edges(vertex_id)))
                     == expected_n_edges;
             }
         ));
     }
 
+    // clang-format on
+
     template <gl::traits::c_instantiation_of<gl::graph> GraphType>
     gl::size_type n_incident_edges_for_fully_connected_vertex(const GraphType& graph) {
         return graph.order() - 1uz;