Skip to content

warning during a bitwise comparison in line 701 of wiring_analog.c #1261

@mikrocoder

Description

@mikrocoder

Hi,

Description
There is a warning during a bitwise comparison in line 701 of wiring_analog.c.

  int8_t getAnalogReadResolution() {
    return ((ADC0.CTRLA & (ADC_RESSEL_bm)) == 1) ? 8 : 10;
  }

Warning:

F:\Arduino IDE Portable\MiniCore\arduino-1.8.19\portable\packages\megaTinyCore\hardware\megaavr\2.6.12\cores\megatinycore\wiring_analog.c: In function 'getAnalogReadResolution':
F:\Arduino IDE Portable\MiniCore\arduino-1.8.19\portable\packages\megaTinyCore\hardware\megaavr\2.6.12\cores\megatinycore\wiring_analog.c:701:44: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
  701 |     return ((ADC0.CTRLA & (ADC_RESSEL_bm)) == 1) ? 8 : 10;

Changes:

diff:
- return ((ADC0.CTRLA & (ADC_RESSEL_bm)) == 1) ? 8 : 10;
+ return (ADC0.CTRLA & ADC_RESSEL_bm) ? 8 : 10;

Environment:
megaTinyCore: 2.6.12
Operating System: Windows 11
Toolchain: avr-gcc 15.2 with avrLibC 2.3.1
Arduino IDE: 1.8.19

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions