Merge pull request #1338 from SpiNNakerManchester/no_java_skip

raise skiptest is java not installed

Author: Christian-B

spinn_front_end_common/interface/java_caller.py

@@ -75,21 +75,32 @@ class JavaCaller(object):
         # Properties flag to be passed to Java
         "_java_properties")
 
-    def __init__(self) -> None:
+    @classmethod
+    def check_java(cls) -> str:
         """
-        Creates a Java caller and checks the user/configuration parameters.
+        Reads and checks the Java call
 
-        :raise ConfigurationException: if simple parameter checking fails.
+        :return: Java call from cfg
+        :raises FileNotFoundError: If no Java installed
+        :raises ConfigurationException: If Java -version failed
         """
-        self._recording: Optional[bool] = None
         java_call = get_config_str("Java", "java_call")
-        self._java_call = java_call
-        result = subprocess.call([self._java_call, '-version'])
+        result = subprocess.call([java_call, '-version'])
         if result != 0:
             raise ConfigurationException(
-                f" {self._java_call} -version failed. "
+                f" {java_call} -version failed. "
                 "Please set [Java] java_call to the absolute path "
                 "to start java. (in config file)")
+        return java_call
+
+    def __init__(self) -> None:
+        """
+        Creates a Java caller and checks the user/configuration parameters.
+
+        :raise ConfigurationException: if simple parameter checking fails.
+        """
+        self._java_call = self.check_java()
+        self._recording: Optional[bool] = None
 
         self._find_java_jar()
 

unittests/interface/test_java_caller.py

@@ -33,6 +33,10 @@ class TestJavaCaller(unittest.TestCase):
 
     def setUp(self) -> None:
         unittest_setup()
+        try:
+            JavaCaller.check_java()
+        except (ConfigurationException, FileNotFoundError):
+            raise unittest.SkipTest("Java not available")
 
     def test_creation_with_jar_path(self) -> None:
         set_config("Java", "java_spinnaker_path", "missing")