Conversation
Note that this requires that we are running against a new enough Python to support RETURNING clauses.
Member
|
This looks good assuming it works. Can we also do something similar with rowcount May also be an idea to convert the DatabaseReader use of fetchone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes our Python code to use a
RETURNINGclause instead of using thelastrowidproperty, mirroring a change already in the Java code. It also gets rid ofDsDatabaseException; plain oldDatabaseExceptionshould be good enough.Note that this requires that we are running against a new enough Python to supportWorks with 3.8 in test.RETURNINGclauses. I don't know if 3.8 is new enough.