Skip to content

Remove version check #1361

Merged
Christian-B merged 6 commits into
masterfrom
docker-compose
May 21, 2026
Merged

Remove version check #1361
Christian-B merged 6 commits into
masterfrom
docker-compose

Conversation

@rowleya
Copy link
Copy Markdown
Member

@rowleya rowleya commented Apr 21, 2026

This check seems unnecessary!

Copilot AI review requested due to automatic review settings April 21, 2026 13:52
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the HBP “machine version” validation when allocating a remote machine, simplifying the HBP allocator flow.

Changes:

  • Drop the Machine.version vs HBP-returned machine["version"] comparison and the associated PacmanConfigurationException.
  • Remove the now-unused get_config_int import from the HBP allocator module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rowleya rowleya requested a review from Christian-B May 19, 2026 09:34
@Christian-B Christian-B merged commit 3c41f35 into master May 21, 2026
13 checks passed
@Christian-B Christian-B deleted the docker-compose branch May 21, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants