Skip to content

Strict bytes #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christian-B merged 3 commits into from
May 19, 2026
Merged

Strict bytes #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1da220e
python_checks.yml@mypy2
Christian-B May 15, 2026
5057114
bytearray
Christian-B May 15, 2026
7561db1
return is a memoryview
Christian-B May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python_actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@

jobs:
call:
uses: SpiNNakerManchester/SupportScripts/.github/workflows/python_checks.yml@main
uses: SpiNNakerManchester/SupportScripts/.github/workflows/python_checks.yml@mypy2
with:
dependencies: SpiNNUtils SpiNNMachine SpiNNMan PACMAN spalloc SpiNNFrontEndCommon TestBase
ubuntu-packages: graphviz
test-directories: unittests
coverage-package: spinnaker_graph_front_end
flake8-packages: spinnaker_graph_front_end unittests gfe_examples
pylint-packages: spinnaker_graph_front_end
mypy-packages:
mypy-full-packages: spinnaker_graph_front_end gfe_examples gfe_integration_tests
cfg-file: spiNNakerGraphFrontEnd

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion gfe_examples/template/template_vertex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def _write_app_memory_regions(self, spec: DataSpecificationGenerator,
spec.write_value(int(key is not None))
spec.write_value(0 if key is None else key)

def read(self) -> bytes:
def read(self) -> memoryview:
"""
Get the recorded data.

Expand Down
4 changes: 2 additions & 2 deletions gfe_integration_tests/test_extra_monitor/test_extra_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def get_data_region_address(placement: Placement, region: DataRegions) -> int:
return transceiver.read_word(placement.x, placement.y, address_location)


def check_data(data: bytes) -> None:
def check_data(data: bytearray) -> None:
# check data is correct here
ints = n_word_struct(len(data) // 4).unpack(data)
start_value = 0
Expand All @@ -57,7 +57,7 @@ def check_data(data: bytes) -> None:

def _do_transfer(gatherer: DataSpeedUpPacketGatherMachineVertex,
receiver_placement: Placement, writer_placement: Placement,
writer_vertex: SDRAMWriter) -> bytes:
writer_vertex: SDRAMWriter) -> bytearray:
with StreamingContextManager(FecDataView.iterate_gathers()):
extra_monitor = receiver_placement.vertex
assert isinstance(extra_monitor, ExtraMonitorSupportMachineVertex)
Expand Down
2 changes: 1 addition & 1 deletion spinnaker_graph_front_end/utilities/simulator_vertex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def placement(self) -> Placement:
return FecDataView.get_placement_of_vertex(self)

def get_recording_channel_data(
self, recording_id: int) -> Tuple[bytes, bool]:
self, recording_id: int) -> Tuple[memoryview, bool]:
"""
Get the data from a recording channel. The simulation must have
:py:func:`spinnaker_graph_front_end.run` before this will work,
Expand Down
Loading