Skip to content

Commit aac1108

Browse files
committed
do you need to inoput python version
1 parent 6a2c854 commit aac1108

2 files changed

Lines changed: 5 additions & 11 deletions

File tree

.github/workflows/python_checks.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,10 @@ jobs:
268268
# cfg-file: ${{ inputs.cfg-file }}
269269
# pip-installs: ${{ inputs.pip-installs }}
270270

271+
- name: Lint with ruff
272+
if: ${{ inputs.run-ruff == 'true' }}
273+
uses: SpiNNakerManchester/SupportScripts/actions/ruff@main
274+
271275
- name: Lint with mypy
272276
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check-prereleases == 'true') && inputs.mypy-packages != '' }}
273277
run: mypy --python-version ${{ matrix.python-version }} ${{ inputs.mypy-packages }}
@@ -290,12 +294,6 @@ jobs:
290294
rcfile: ${{ inputs.rcfile }}
291295
language: en_GB
292296

293-
- name: Lint with ruff
294-
if: ${{ inputs.run-ruff == 'true' }}
295-
uses: SpiNNakerManchester/SupportScripts/actions/ruff@main
296-
with:
297-
python_version: ${{ inputs.pylint-packages }}
298-
299297
- name: Test with pytest
300298
if: ${{ (matrix.python-version != env.PRERELEASE || inputs.check-prereleases == 'true') && inputs.test-directories != ''}}
301299
uses: SpiNNakerManchester/SupportScripts/actions/pytest@main

actions/ruff/action.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,11 @@ name: "Lint with ruff"
1717
description: >
1818
Runs the ruff check
1919
20-
inputs:
21-
python-version:
22-
description: The python version to use
23-
required: true
24-
2520
runs:
2621
using: composite
2722
steps:
2823
- run: |
24+
echo run ruff with current version
2925
if [[ ${{ matrix.python-version}} = 3.10 ]]; then
3026
echo ruff check --target-version py310
3127
ruff check --target-version py310

0 commit comments

Comments
 (0)