Merge pull request #1568 from SpiNNakerManchester/pylint

Pylint

Author: Christian-B

spynnaker/_version.py

@@ -18,4 +18,4 @@
 __version_day__ = "TBD"
 __version_name__ = "To Do"
 
-_NAME = f"sPyNNaker_under_version({__version__}-{__version_name__})"
+NAME = f"sPyNNaker_under_version({__version__}-{__version_name__})"

spynnaker/pyNN/__init__.py

@@ -304,7 +304,7 @@ def setup(timestep: Optional[Union[float, Literal["auto"]]] = None,
         ~spinn_front_end_common.utilities.exceptions.ConfigurationException:
         if both ``n_chips_required`` and ``n_boards_required`` are used.
     """
-    # pylint: disable=global-statement,too-many-arguments
+    # pylint: disable=global-statement
     # Check for "auto" values and None
     global __simulator
     if timestep is None:
@@ -395,7 +395,6 @@ def Projection(
     :return: a projection object for SpiNNaker
     :rtype: ~spynnaker.pyNN.models.projection.Projection
     """
-    # pylint: disable=too-many-arguments
     return SpiNNakerProjection(
         pre_synaptic_population=presynaptic_population,
         post_synaptic_population=postsynaptic_population, connector=connector,
@@ -555,7 +554,6 @@ def connect(pre: Population, post: Population, weight: float = 0.0,
     :param float p: probability
     :param ~pyNN.random.NumpyRNG rng: random number generator
     """
-    # pylint: disable=too-many-arguments
     SpynnakerDataView.check_user_can_act()
     __pynn["connect"](pre, post, weight, delay, receptor_type, p, rng)
 

spynnaker/pyNN/connections/spif_live_spikes_connection.py

@@ -105,7 +105,6 @@ def __init__(self, receive_labels: Optional[Iterable[str]],
             the port that the toolchain will send the notification on (19999
             by default)
         """
-        # pylint: disable=too-many-arguments
         super().__init__(
             self.__do_start_resume, self.__do_stop_pause,
             local_host=local_host, local_port=local_port)

spynnaker/pyNN/connections/spynnaker_live_spikes_connection.py

@@ -47,7 +47,6 @@ def __init__(self, receive_labels: Optional[Iterable[str]] = None,
             the port that the toolchain will send the notification on (19999
             by default)
         """
-        # pylint: disable=too-many-arguments
         super().__init__(
             live_packet_gather_label, receive_labels, send_labels,
             local_host, local_port)

spynnaker/pyNN/data/spynnaker_data_view.py

@@ -56,7 +56,6 @@ class _SpynnakerDataModel(object):
     def __new__(cls) -> '_SpynnakerDataModel':
         if cls.__singleton is not None:
             return cls.__singleton
-        # pylint: disable=protected-access
         obj = object.__new__(cls)
         cls.__singleton = obj
         obj._clear()
@@ -97,7 +96,6 @@ class SpynnakerDataView(FecDataView):
     Use this class wherever possible as it inherits all methods from all View
     classes.
     """
-    # pylint: disable=attribute-defined-outside-init
 
     __spy_data = _SpynnakerDataModel()
 
@@ -241,4 +239,4 @@ def get_sim_name(cls) -> str:
 
         :rtype: str
         """
-        return _version._NAME   # pylint: disable=protected-access
+        return _version.NAME

spynnaker/pyNN/external_devices/__init__.py

@@ -239,7 +239,7 @@ def EthernetControlPopulation(
     :rtype: ~spynnaker.pyNN.models.populations.Population
     :raises TypeError: If an invalid model class is used.
     """
-    # pylint: disable=too-many-arguments, global-statement
+    # pylint: disable=global-statement
     population = Population(n_neurons, model, label=label)
     vertex, aec, vertex_label = __vtx(population)
     translator = aec.get_message_translator()

spynnaker/pyNN/external_devices_models/arbitrary_fpga_device.py

@@ -41,7 +41,6 @@ def __init__(
         :param label:
         :type label: str or None
         """
-        # pylint: disable=too-many-arguments
         conn = FPGAConnection(
             fpga_id, fpga_link_id, board_address, chip_coords)
         super().__init__(n_neurons, [conn], conn, label)

spynnaker/pyNN/external_devices_models/external_device_lif_control.py

@@ -83,8 +83,6 @@ def __init__(
         :param float isyn_inh:
             (defaulted LIF neuron state variable initial value)
         """
-        # pylint: disable=too-many-arguments
-
         if not devices:
             raise ConfigurationException("No devices specified")
 

spynnaker/pyNN/external_devices_models/external_device_lif_control_vertex.py

@@ -93,7 +93,6 @@ def __init__(
         :type splitter: SplitterPopulationVertex or None
         :param int n_colour_bits: The number of colour bits to use
         """
-        # pylint: disable=too-many-arguments
         if drop_late_spikes is None:
             drop_late_spikes = False
         extra_partition_ids = [

spynnaker/pyNN/external_devices_models/external_spinnaker_link_fpga_retina_device.py

@@ -104,7 +104,6 @@ def __init__(
         :param str label:
         :param str board_address:
         """
-        # pylint: disable=too-many-arguments
         fixed_n_neurons = self.get_n_neurons(mode, polarity)
         super().__init__(
             n_atoms=fixed_n_neurons, spinnaker_link_id=spinnaker_link_id,