Skip to content

overrides no longer check typing or parameters #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Christian-B merged 7 commits into from
Jun 5, 2025
Merged

overrides no longer check typing or parameters #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d0e3b56
adds_typing not needed
Christian-B May 16, 2025
f629c6d
remove stuff pylint does from overrides
Christian-B May 16, 2025
e034902
# type: ignore[has-type]
Christian-B May 16, 2025
8862b5b
Merge branch 'master' into less_overrides
Christian-B May 16, 2025
6f5e391
correct # type: ignore[has-type]
Christian-B May 16, 2025
03553a0
Merge branch 'master' into less_overrides
Christian-B Jun 3, 2025
e1e2501
Merge branch 'master' into less_overrides
Christian-B Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/neuron/abstract_pynn_neuron_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ def __init__(self, model: AbstractNeuronImpl):
def _model(self) -> AbstractNeuronImpl:
return self.__model

@overrides(AbstractPyNNModel.create_vertex,
additional_arguments=_population_parameters.keys())
@overrides(AbstractPyNNModel.create_vertex)
def create_vertex(
self, n_neurons: int, label: str, *,
spikes_per_second: Optional[float] = None,
Expand Down
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/neuron/abstract_pynn_neuron_model_standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ def __init__(
model_name, binary, neuron_model, input_type, synapse_type,
threshold_type, additional_input_type))

@overrides(AbstractPyNNNeuronModel.create_vertex, # type: ignore[has-type]
additional_arguments={"n_steps_per_timestep"})
@overrides(AbstractPyNNNeuronModel.create_vertex) # type: ignore[has-type]
def create_vertex(
self, n_neurons: int, label: str, *,
spikes_per_second: Optional[float] = None,
Expand Down
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/spike_source/spike_source_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ def __init__(self, spike_times: Optional[Spikes] = None):
spike_times = []
self.__spike_times = spike_times

@overrides(AbstractPyNNModel.create_vertex,
additional_arguments=default_population_parameters.keys())
@overrides(AbstractPyNNModel.create_vertex)
def create_vertex(
self, n_neurons: int, label: str, *,
splitter: Optional[AbstractSplitterCommon] = None,
Expand Down
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/spike_source/spike_source_poisson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ def absolute_max_atoms_per_core( # pylint: disable=no-self-argument
cls) -> int:
return DEFAULT_MAX_ATOMS_PER_CORE

@overrides(AbstractPyNNModel.create_vertex,
additional_arguments=default_population_parameters.keys())
@overrides(AbstractPyNNModel.create_vertex)
def create_vertex(
self, n_neurons: int, label: str, *,
seed: Optional[int] = None, max_rate: Optional[float] = None,
Expand Down
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/spike_source/spike_source_poisson_variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ def absolute_max_atoms_per_core( # pylint: disable=no-self-argument
cls) -> int:
return DEFAULT_MAX_ATOMS_PER_CORE

@overrides(AbstractPyNNModel.create_vertex,
additional_arguments=default_population_parameters.keys())
@overrides(AbstractPyNNModel.create_vertex)
def create_vertex(
self, n_neurons: int, label: str, *, seed: Optional[int] = None,
splitter: Optional[AbstractSplitterCommon] = None
Expand Down
3 changes: 1 addition & 2 deletions spynnaker/pyNN/models/utility_models/spike_injector/spike_injector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ class SpikeInjector(AbstractPyNNModel):

default_population_parameters = _population_parameters

@overrides(AbstractPyNNModel.create_vertex,
additional_arguments=_population_parameters.keys())
@overrides(AbstractPyNNModel.create_vertex)
def create_vertex(
self, n_neurons: int, label: str, *,
port: Optional[int] = None, virtual_key: Optional[int] = None,
Expand Down
2 changes: 1 addition & 1 deletion spynnaker/pyNN/utilities/data_population.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def write_data(self, io: Union[str, neo.baseio.BaseIO],
# write the neo block to the file
io.write(bl=data)

@overrides(Population.describe, adds_typing=True)
@overrides(Population.describe)
def describe(self, template: Optional[str] = None,
engine: Optional[Union[str, TemplateEngine]] = None
) -> Union[str, Dict[str, Any]]:
Expand Down
Loading