Pylint

[Christian-B]

similar to SpiNNakerManchester/SpiNNUtils#302

code changes:
rename version._NAME version.NAME

projection/ population/PopulationBase

• _we_dont_do_this_now thin wrapper method removed.

AbstractSynapseDynamics.get_provenance_data unused do nothing method removed

PushBotRetinaViewer __run removed run_thread param

SmallWorldConnector error raised if allow_self_connections is false

SynapticMatrixApp remove unused __delay_index

PopulationVertex._ring_buffer_expected_upper_bound moved to _Stats

---

Still used disables

Many classes

• invalid-name
  • Param names defined by PyNN
  • Module name "pyNN" doesn't conform to snake_case naming style
• protected-access
  • calling None PyNN methods on Populations, Projections, Model or Synapse information
• import-outside-toplevel
  • circular import

spynnaker/pyNN/init.py

• import-self
  • used when copied into pyNN.spiNNaker
• global-statement
  • The simulator.
• broad-except
  • logger.exception("Error forcing previous simulation to clear")
• protected-access
  • external_devices._set_simulator(__simulator)

spynnaker/pyNN/random_distribution.py

• useless-super-delegation
  • not sure why but it is commented as needed

spynnaker/pyNN/types.py

• no-member
  • "Module 'neo' has no 'baseio' member (no-member)"

spynnaker/pyNN/connections/spynnaker_live_spikes_connection.py

• broad-except
  • log and move on

spynnaker/pyNN/data/spynnaker_data_view.py

• protected-access
  • hide the data in the model

spynnaker/pyNN/data/spynnaker_data_writer.py

• protected-access
  • hide the data in the model

spynnaker/pyNN/external_devices/init.py

• global-statement
  • __ethernet_control_connection
  • __simulator

spynnaker/pyNN/external_devices_models/push_bot/ethernet/push_bot_retina_connection.py

• consider-using-enumerate
  • uses not just data[i] but also data[i:i+2]

spynnaker/pyNN/external_devices_models/push_bot/ethernet/push_bot_translator.py

• too-many-statements, too-many-branches
  • clean blocks would only get messier to avoid

spynnaker/pyNN/external_devices_models/push_bot/ethernet/push_bot_wifi_connection.py

• broad-except
  • ignore exceptions on close

spynnaker/pyNN/external_devices_models/push_bot/parameters/push_bot_retina_viewer.py

• import-outside-toplevel
  • pyNN.spiNNaker (same if spynnaker.PyNN) is used
• broad-except
  • log

spynnaker/pyNN/extra_algorithms/redundant_packet_count_report.py

• broad-except
  • log and stop the report

spynnaker_neuron_network_specification_report.py

• import-error,import-outside-toplevel
  • Dont require graphviz

spynnaker/pyNN/models/abstract_pynn_model.py

• no-self-argument
  • @classproperty
• no-member
  • on the class property

spynnaker/pyNN/models/defaults.py

• protected-access
  • method methods
• no-self-argument
  • @classproperty

spynnaker/pyNN/models/projection.py

• redefined-builtin
• "format" param name defined by PyNN

spynnaker/pyNN/models/abstract_models/sends_synaptic_inputs_over_sdram.py

• abstract-method
  • interface

spynnaker/pyNN/models/common/population_application_vertex.py

• abstract-method
  • is abstract

spynnaker/pyNN/models/neural_projections/projection_application_edge.py

• isinstance-second-argument-not-valid-type
  • Type comes from a method

spynnaker/pyNN/models/neural_projections/connectors/from_list_connector.py

• wrong-spelling-in-comment
  • numpy.ptp

spynnaker/pyNN/models/neural_projections/connectors/pool_dense_connector.py

• no-member
• see PoolDenseConnector weights is always an ndarray #1436

spynnaker/pyNN/models/neuron/master_pop_table.py

• no-member, protected-access
  • ctypes._CData

spynnaker/pyNN/models/neuron/population_machine_common.py

• abstract-method
• Abstract Class

spynnaker/pyNN/models/neuron/population_machine_synapses.py

• missing-function-docstring
  • overirdes not from super
  • checked it works on https://spynnaker.readthedocs.io/en/latest/spynnaker.pyNN.models.neuron/#spynnaker.pyNN.models.neuron.population_machine_synapses.PopulationMachineSynapses

spynnaker/pyNN/models/neuron/population_vertex.py

• no-member
  • scipy.special gammaln and gammaincc

spynnaker/pyNN/models/neuron/additional_inputs/abstract_additional_input.py

• abstract-method
  • zero methods abstract

spynnaker/pyNN/models/neuron/builds/eif_cond_alpha_isfa_ista.py

• Not supported

spynnaker/pyNN/models/neuron/builds/hh_cond_exp.py

• Not supported

spynnaker/pyNN/models/neuron/builds/if_cond_alpha.py

• Not supported

spynnaker/pyNN/models/neuron/builds/if_curr_delta_ca2_adaptive.py

• wrong-spelling-in-docstring
  • Math abbreviation from book

spynnaker/pyNN/models/neuron/builds/if_facets_hardware1.py

• Not supported

spynnaker/pyNN/models/neuron/local_only/local_only_convolution.py

• protected-access
  • PopulationMachineCommon._pop_vertex
• unexpected-keyword-arg
  • numpy.concatenate does have dtype

spynnaker/pyNN/models/neuron/neuron_models/neuron_model.py

• abstract-method
  • zero methods abstract

spynnaker/pyNN/models/neuron/plasticity/stdp/timing_dependence/timing_dependence_pfister_spike_triplet.py

• wrong-spelling-in-docstring
  • book reference

spynnaker/pyNN/models/neuron/plasticity/stdp/timing_dependence/timing_dependence_recurrent.py

• protected-access
  • Other is same class

spynnaker/pyNN/models/neuron/plasticity/stdp/weight_dependence/weight_dependence_additive.py

• wrong-spelling-in-comment
  • Math symbols

spynnaker/pyNN/models/neuron/synapse_dynamics/synapse_dynamics_stdp.py

• protected-access
  • Other is same class

spynnaker/pyNN/models/neuron/synapse_dynamics

• unidiomatic-typecheck
  • comparing type of two objects

spynnaker/pyNN/models/neuron/threshold_types/abstract_threshold_type.py

• abstract-method
  • api with no method

spynnaker/pyNN/models/populations/population.py

• redefined-builtin
  • PyNN "id"

spynnaker/pyNN/models/populations/population_base.py

• redefined-builtin
  • PyNN "id"

spynnaker/pyNN/models/populations/population_view.py

• redefined-builtin
  • PyNN "id"

spynnaker/pyNN/models/spike_source/spike_source_poisson.py

• no-self-argument
  • classproperty

spynnaker/pyNN/models/spike_source/spike_source_poisson_machine_vertex.py

• missing-function-docstring
  • AbstractMaxSpikes ?????????

spynnaker/pyNN/models/spike_source/spike_source_poisson_variable.py

• no-self-argument
  • classproperty

spynnaker/pyNN/protocols/munich_io_ethernet_protocol.py

• invalid-name
  • all cap methods ?

spynnaker/pyNN/utilities/constants.py

• wrong-spelling-in-comment
  • From neuron common-typedefs.h

spynnaker/pyNN/utilities/data_population.py

• missing-function-docstring
  • overide a none super classes
• redefined-builtin
  • PyNN "id"

spynnaker/pyNN/utilities/neo_buffer_database.py

• no-member
  • call of method on a projected attribute of super

random_stats_vonmises_impl.py

• wrong-spelling-in-docstring
  • name of the method

spynnaker_integration_tests/test_stdp/test_STDP_triplet_additive.py

• nested-min-max
  • inner maxed objects are lists and there is an addition too