Refactor builder panels: modularize controls and split left/right panels#53
Open
a5sh wants to merge 1 commit into
Open
Refactor builder panels: modularize controls and split left/right panels#53a5sh wants to merge 1 commit into
a5sh wants to merge 1 commit into
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
posterium-frontend | ee5a418 | Commit Preview URL Branch Preview URL |
May 08 2026, 06:17 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/components/builder/components/controls/BuilderControls.tsx(Section, SliderRow, ToggleRow, SegmentedRow, TextInputRow, SelectBox, ColorRow) and replaced many inline copies inPropertyPanelandLayerPanelwith these controls.src/components/builder/components/panels/(left/SourcePanel,left/LayersPanel,left/PosterPanel,right/BadgesPanel,right/SelectionPanel) and addedAdvancedPanelHost+AdvancedPanelListto drive the advanced left rail.PanelSwitcher(components/layout/PanelSwitcher.tsx) and aBuilderModeToggle(components/layout/BuilderModeToggle.tsx) and wired the header to use the new mode toggle instead of the previous support CTA.LayerPanel,PropertyPanel,Inspector,AdvancedBuilderApp, and the simpleBuilderAppcomposition to load the new per-panel modules (desktop sidebars and mobile sheet), and introduced aforcedPanelprop so the same panel can be hosted in different layouts without duplicating logic.Testing
npm run build, which completed successfully and produced static pages (build ✓).npm test; Vitest returned “No test files found” (exit indicates no tests were executed).npm run typecheck; TypeScript reported remaining type errors unrelated to the refactor (pre-existing repo type debt in admin analytics, command palette/preview canvas unused symbols, and a few other files), so typecheck did not fully pass.Codex Task