Skip to content

Commit 8b6db0e

Browse files
authored
Merge pull request #20 from SpikeInterface/correct-spec-units
Few modifications to spec descriptions
2 parents ea53a47 + f0b9e1b commit 8b6db0e

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

spec/ndx-probeinterface.extensions.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ groups:
5959
- 2
6060
- - null
6161
- 3
62-
doc: dimension of the probe
62+
doc: position of the contact
6363
- name: contact_shape
6464
neurodata_type_inc: VectorData
6565
dtype: text
@@ -91,25 +91,25 @@ groups:
9191
- - null
9292
- 2
9393
- 3
94-
doc: dimension of the probe
94+
doc: the axes defining the contact plane
9595
quantity: '?'
9696
- name: radius
9797
neurodata_type_inc: VectorData
9898
dtype: float
99-
doc: Radius of a circular contact
99+
doc: radius of a circular contact
100100
quantity: '?'
101101
- name: width
102102
neurodata_type_inc: VectorData
103103
dtype: float
104-
doc: Width of a rectangular or square contact
104+
doc: width of a rectangular or square contact
105105
quantity: '?'
106106
- name: height
107107
neurodata_type_inc: VectorData
108108
dtype: float
109-
doc: Height of a rectangular contact
109+
doc: height of a rectangular contact
110110
quantity: '?'
111111
- name: device_channel_index_pi
112112
neurodata_type_inc: VectorData
113113
dtype: int
114-
doc: ID of the channel connected to the contact
114+
doc: index of the channel connected to the contact
115115
quantity: '?'

src/spec/create_extension_spec.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def main():
3030
datasets=[
3131
NWBDatasetSpec(
3232
name="contact_position",
33-
doc="dimension of the probe",
33+
doc="position of the contact",
3434
dtype="float",
3535
dims=[["num_contacts", "x, y"], ["num_contacts", "x, y, z"]],
3636
shape=[[None, 2], [None, 3]],
@@ -58,7 +58,7 @@ def main():
5858
),
5959
NWBDatasetSpec(
6060
name="contact_plane_axes",
61-
doc="dimension of the probe",
61+
doc="the axes defining the contact plane",
6262
dtype="float",
6363
dims=[["num_contacts", "v1, v2", "x,y"], ["num_contacts", "v1,v2", "x, y, z"]],
6464
shape=[[None, 2, 2], [None, 2, 3]],
@@ -67,28 +67,28 @@ def main():
6767
),
6868
NWBDatasetSpec(
6969
name="radius",
70-
doc="Radius of a circular contact",
70+
doc="radius of a circular contact",
7171
dtype="float",
7272
neurodata_type_inc="VectorData",
7373
quantity="?",
7474
),
7575
NWBDatasetSpec(
7676
name="width",
77-
doc="Width of a rectangular or square contact",
77+
doc="width of a rectangular or square contact",
7878
dtype="float",
7979
neurodata_type_inc="VectorData",
8080
quantity="?",
8181
),
8282
NWBDatasetSpec(
8383
name="height",
84-
doc="Height of a rectangular contact",
84+
doc="height of a rectangular contact",
8585
dtype="float",
8686
neurodata_type_inc="VectorData",
8787
quantity="?",
8888
),
8989
NWBDatasetSpec(
9090
name="device_channel_index_pi",
91-
doc="ID of the channel connected to the contact",
91+
doc="index of the channel connected to the contact",
9292
dtype="int",
9393
neurodata_type_inc="VectorData",
9494
quantity="?",

0 commit comments

Comments
 (0)